Re: [quicwg/base-drafts] Better describe the use of Preferred Address (#3354)

Mike Bishop <notifications@github.com> Fri, 17 January 2020 18:08 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 22E15120089 for <quic-issues@ietfa.amsl.com>; Fri, 17 Jan 2020 10:08:02 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rId98WvNn9GU for <quic-issues@ietfa.amsl.com>; Fri, 17 Jan 2020 10:07:56 -0800 (PST)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B598112007A for <quic-issues@ietf.org>; Fri, 17 Jan 2020 10:07:56 -0800 (PST)
Date: Fri, 17 Jan 2020 10:07:55 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579284475; bh=9RsEyXFMia9wmV26mqaPyvaZK78zv46ltVktMQ22W9c=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=FhuozuwkyoTcnPeAXmr8G/YCLBUJp+5/+bnOM9xCH1L61XwMyE1D8R7PwtecYD9cR YQ45fqZEOaBy7sOJ4Bdgi1+D+lXYxBVqBrOmRytiN2QQCjBN5/QPtvNKtXc02Hr/Ub nTl6OxiUv0SyaUsYTnwRgVw+o73vCnk/MOxP3f10=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5YF3THGHWAHRUZASF4F4VHXEVBNHHCBWRIJQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3354/review/344750056@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3354@github.com>
References: <quicwg/base-drafts/pull/3354@github.com>
Subject: Re: [quicwg/base-drafts] Better describe the use of Preferred Address (#3354)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e21f7fb9cbe1_793f3fcb540cd960881b7"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/aLXU9lrSBdbMQqVVVXvZqRxPQ8s>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jan 2020 18:08:02 -0000

MikeBishop commented on this pull request.

I'm not totally sold on dissociating the CID from the preferred address, but the rest of this looks like a net improvement.  I'll address that one the issue.

> @@ -4635,8 +4634,12 @@ preferred_address (0x000d):
   transport parameter is only sent by a server. Servers MAY choose to only send
   a preferred address of one address family by sending an all-zero address and
   port (0.0.0.0:0 or ::.0) for the other family. IP addresses are encoded in
-  network byte order. The CID Length field contains the length of the
-  Connection ID field.
+  network byte order. The Connection ID field and the Stateless Reset Token
+  field contain the alternative connection ID that is assigned the sequence
+  number of one ({{issue-cid}}). Having them bundled with the  preferred address

```suggestion
  number of one ({{issue-cid}}). Having them bundled with the preferred address
```

> @@ -4635,8 +4634,12 @@ preferred_address (0x000d):
   transport parameter is only sent by a server. Servers MAY choose to only send
   a preferred address of one address family by sending an all-zero address and
   port (0.0.0.0:0 or ::.0) for the other family. IP addresses are encoded in
-  network byte order. The CID Length field contains the length of the
-  Connection ID field.
+  network byte order. The Connection ID field and the Stateless Reset Token
+  field contain the alternative connection ID that is assigned the sequence
+  number of one ({{issue-cid}}). Having them bundled with the  preferred address
+  ensures that there would be at least one unused active connection ID when the

```suggestion
  ensures that there will be at least one unused active connection ID when the
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3354#pullrequestreview-344750056