Re: [quicwg/base-drafts] Proposed fix for #3987 (#4071)
ianswett <notifications@github.com> Thu, 03 September 2020 18:59 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5BDB13A1167 for <quic-issues@ietfa.amsl.com>; Thu, 3 Sep 2020 11:59:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.697
X-Spam-Level:
X-Spam-Status: No, score=-1.697 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4m-J1Vn8JGaz for <quic-issues@ietfa.amsl.com>; Thu, 3 Sep 2020 11:58:59 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0B1CF3A1166 for <quic-issues@ietf.org>; Thu, 3 Sep 2020 11:58:59 -0700 (PDT)
Received: from github-lowworker-f045d1f.ac4-iad.github.net (github-lowworker-f045d1f.ac4-iad.github.net [10.52.19.54]) by smtp.github.com (Postfix) with ESMTP id 437C85C0428 for <quic-issues@ietf.org>; Thu, 3 Sep 2020 11:58:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1599159538; bh=aD9AgSNOWJwnmBvrb62GKRQDT8pjQX+T4cnPCAv+gWo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ASTg5P0I6/s+uKCVSQVG/TGh5S/ARckY0Ivr8I1xMM36IsYACM5BqtZN7Xkbf/SBp 54sR4N59Axg9Cf4dx8gjYa+enycHytpXHdQgAV2d/WDA6Afh22shRpxy879wNMxlw1 JWTTvjkMPqBhB2KXh1yN7qGeoic99gFcKx50r6Uc=
Date: Thu, 03 Sep 2020 11:58:58 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3E55UOGTYGK2TOMSF5LUO7FEVBNHHCSPRX6E@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4071/review/482118572@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4071@github.com>
References: <quicwg/base-drafts/pull/4071@github.com>
Subject: Re: [quicwg/base-drafts] Proposed fix for #3987 (#4071)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f513cf233f6a_43ea19f055047"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/aLsIkJmJzuFTKpI3NNUqTgE17Mc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Sep 2020 18:59:00 -0000
@ianswett commented on this pull request. I think we're using PTO in two cases because we want to allow time for the PTO to fire twice, but I could be wrong? > @@ -2214,6 +2214,11 @@ defined in {{QUIC-RECOVERY}} is RECOMMENDED. That is: validation_timeout = max(3*PTO, 6*kInitialRtt) ~~~ +The PTO includes the peer's maximum expected acknowledgement delay. This is not In this case, we use PTO to allow for the PTO to fire twice before giving up, correct? I think explaining it in terms of max ack delay is confusing. > @@ -2693,6 +2698,10 @@ ensures that connections are not closed after new activity is initiated. To avoid excessively small idle timeout periods, endpoints MUST increase the idle timeout period to be at least three times the current Probe Timeout (PTO). +As defined in {{QUIC-RECOVERY}}, the PTO includes the peer's maximum expected Again, I think 3 * PTO is so there is sufficient opportunity for the PTO to fire before the connection idle timeouts? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/4071#pullrequestreview-482118572
- [quicwg/base-drafts] Proposed fix for #3987 (#407… Lars Eggert
- Re: [quicwg/base-drafts] Proposed fix for #3987 (… ianswett
- Re: [quicwg/base-drafts] Proposed fix for #3987 (… Lars Eggert
- Re: [quicwg/base-drafts] Proposed fix for #3987 (… Jana Iyengar
- Re: [quicwg/base-drafts] Proposed fix for #3987 (… Lars Eggert
- Re: [quicwg/base-drafts] Proposed fix for #3987 (… Lars Eggert
- Re: [quicwg/base-drafts] Proposed fix for #3987 (… Lars Eggert
- Re: [quicwg/base-drafts] Proposed fix for #3987 (… ianswett
- Re: [quicwg/base-drafts] Proposed fix for #3987 (… ianswett
- Re: [quicwg/base-drafts] Proposed fix for #3987 (… Lars Eggert
- Re: [quicwg/base-drafts] Proposed fix for #3987 (… Benjamin Saunders
- Re: [quicwg/base-drafts] Proposed fix for #3987 (… Jana Iyengar
- Re: [quicwg/base-drafts] Proposed fix for #3987 (… Martin Thomson
- Re: [quicwg/base-drafts] Proposed fix for #3987 (… Lars Eggert
- Re: [quicwg/base-drafts] Proposed fix for #3987 (… Lars Eggert
- Re: [quicwg/base-drafts] Proposed fix for #3987 (… ianswett
- Re: [quicwg/base-drafts] Proposed fix for #3987 (… Jana Iyengar
- Re: [quicwg/base-drafts] Proposed fix for #3987 (… Jana Iyengar
- Re: [quicwg/base-drafts] Proposed fix for #3987 (… Martin Thomson