Re: [quicwg/base-drafts] use TRANSPORT_PARAMETER_ERROR when authenticating connection IDs (#3691)

Kazuho Oku <notifications@github.com> Wed, 27 May 2020 05:47 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A52F73A07C2 for <quic-issues@ietfa.amsl.com>; Tue, 26 May 2020 22:47:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RpigQBycFDt7 for <quic-issues@ietfa.amsl.com>; Tue, 26 May 2020 22:46:59 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 443323A07BD for <quic-issues@ietf.org>; Tue, 26 May 2020 22:46:59 -0700 (PDT)
Received: from github-lowworker-5825cd4.ac4-iad.github.net (github-lowworker-5825cd4.ac4-iad.github.net [10.52.22.68]) by smtp.github.com (Postfix) with ESMTP id 23049521925 for <quic-issues@ietf.org>; Tue, 26 May 2020 22:46:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1590558418; bh=oVwBrNxFpPDCbHT7wBd2yjKo6+BR/B55l6uxyouU+P4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Rsf7oJ8dWs3BwUGaC3up2jzSIjdgAHAsUUtUPODQLlWDBIZAjd1Mqs/y36y+WO75k 5sAM6TNFv29LZGxuo5pyi60MxQLB/Y5TWfVqis7q0FHY/vM9sK7I2nE1aiW/uu7vG1 eeq+v7Qob9njpMXECD1hbO7ghbTtJ/eAxSoQKu3A=
Date: Tue, 26 May 2020 22:46:58 -0700
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3XRFURNEMFQNJCOCF43HP5FEVBNHHCKLSLMI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3691/review/418872644@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3691@github.com>
References: <quicwg/base-drafts/pull/3691@github.com>
Subject: Re: [quicwg/base-drafts] use TRANSPORT_PARAMETER_ERROR when authenticating connection IDs (#3691)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ecdfed212937_3a373fa97c2cd96c7933e6"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/aNoOvfSRnbjl8oSx-MlRQs7xiSU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 May 2020 05:47:01 -0000

@kazuho commented on this pull request.



>  
-* absence of the original_destination_connection_id transport parameter from
-  the server,
+An endpoint MUST treat the following as a connection error of type
+PROTOCOL_VIOLATION:
 
 * absence of the retry_source_connection_id transport parameter from the server
   after receiving a Retry packet,

I think my preference would be to allow either PROTOCOL_VIOLATION or TRANSPORT_PARAMETER_ERROR to be used when retry_source_connection_id is missing (or when it exists for no reason).

This is borderline, and in the past, we have allowed more than one error code to be used when that is reasonable. In this specific case, the QUIC stack can ask the decoder of Transport Parameters to provide source_connection_id (or to not provide one). In such a design, it is reasonable for the decoder of the Transport Parameters to raise an error when that expectation does not match.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3691#pullrequestreview-418872644