Re: [quicwg/base-drafts] Simplify SETTINGS payload (#1807)

Mike Bishop <notifications@github.com> Thu, 27 September 2018 23:10 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7FBF7130DE4 for <quic-issues@ietfa.amsl.com>; Thu, 27 Sep 2018 16:10:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.989
X-Spam-Level:
X-Spam-Status: No, score=-7.989 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ttPyeNNPBAFg for <quic-issues@ietfa.amsl.com>; Thu, 27 Sep 2018 16:10:24 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9C786129C6A for <quic-issues@ietf.org>; Thu, 27 Sep 2018 16:10:24 -0700 (PDT)
Date: Thu, 27 Sep 2018 16:10:23 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1538089823; bh=WorXSZywjp6o77XtBfhM9bYTVG/VEdNTw/JS9rPSPoc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=QvAP6DIInFG6XcuHIHqOmgvNBcjprGNffOl6cIsFpyxiIHGQ46h95HP0VgcbOUnC7 dAcfEl1IqiCQdJfPU92dXUAzVlU8N+9yMWK/pahP26lqKX5DYF2O7fvEYlSYvNUrpI 4EQp1CJIY1Zqt8NHDuuXXJrW67fKt3Aez69YuGuA=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab1156772d9f824d10d778aed7a0b08fc70a781c3692cf0000000117c5255f92a169ce15bb4e07@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1807/review/159674254@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1807@github.com>
References: <quicwg/base-drafts/pull/1807@github.com>
Subject: Re: [quicwg/base-drafts] Simplify SETTINGS payload (#1807)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bad635fc578a_6d883fa4b56d45b810077f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/aNqL9zvYKdTny-ycfODyEGfAi-Y>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Sep 2018 23:10:26 -0000

MikeBishop commented on this pull request.



> @@ -1478,6 +1469,12 @@ SETTINGS_MAX_FRAME_SIZE:
 SETTINGS_MAX_HEADER_LIST_SIZE:
 : See {{settings-parameters}}.
 
+In HTTP/QUIC, setting values are variable-length integers (6, 14, 30, or 62 bits
+long) rather than fixed-length 32-bit fields.  This will often produce a shorter
+encoding, but will produce a longer encoding for settings which use the full
+32-bit space.  Settings ported from HTTP/2 might choose to redefine the format
+of their settings to avoid using the 62-bit encoding.

Secondary Certs currently stuffs an exporter in the setting value (to confirm both peers are on the same TLS connection with no MitM), and would overflow to an eight-byte field.  It doesn't *require* changes, but it's advisable to either take advantage of the entire eight bytes or trim two bits off to still fit in four bytes.  Hence, "might choose."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1807#discussion_r221103830