Re: [quicwg/base-drafts] Notify the congestion controller of losses first (#3540)

Kazu Yamamoto <notifications@github.com> Wed, 08 July 2020 05:27 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F26F23A07F3 for <quic-issues@ietfa.amsl.com>; Tue, 7 Jul 2020 22:27:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dCSQjF8_kOKJ for <quic-issues@ietfa.amsl.com>; Tue, 7 Jul 2020 22:27:49 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B14553A07B9 for <quic-issues@ietf.org>; Tue, 7 Jul 2020 22:27:49 -0700 (PDT)
Received: from github-lowworker-fa7043e.ash1-iad.github.net (github-lowworker-fa7043e.ash1-iad.github.net [10.56.109.45]) by smtp.github.com (Postfix) with ESMTP id E4A00E0A7E for <quic-issues@ietf.org>; Tue, 7 Jul 2020 22:27:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1594186068; bh=F/OYcTj4+4rVbeH0jMVtGfUjxA8SXmOfdPdlYCUxXO0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=1TLK/txtZGn8sMtUW9DFZ2fk8shIldDleJrUoYvvoHCy2iH7FmQ1mH7JlQqXlSqw/ sn4aBO1UCbTPY47QcFNQb3Kvd1A6DIUvnBelAoZGzsUxcsNoQQB5O3xxFr78p5TXh/ 3br+ANJ/8miWgJNGP6cM9V5YH1TUSTaPQar/1/vk=
Date: Tue, 07 Jul 2020 22:27:48 -0700
From: Kazu Yamamoto <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3HMWUIPD5AZ6XY5NN5CE5FJEVBNHHCF2VMJI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3540/review/444422461@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3540@github.com>
References: <quicwg/base-drafts/pull/3540@github.com>
Subject: Re: [quicwg/base-drafts] Notify the congestion controller of losses first (#3540)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f055954d655c_272c3f87764cd9604487b"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazu-yamamoto
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/aa3ET7yMQm3P73vtxUN9v3Oaqn8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jul 2020 05:27:51 -0000

@kazu-yamamoto commented on this pull request.



> @@ -1108,14 +1108,18 @@ OnAckReceived(ack, pn_space):
     largest_acked_packet[pn_space] =
         max(largest_acked_packet[pn_space], ack.largest_acked)
 
+  // DetectNewlyAckedPackets finds packets that are newly

`DetectNewlyAckedPackets` is not defined in `master`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3540#pullrequestreview-444422461