IETF Logo Mail Archive

Re: [quicwg/base-drafts] Minor edits to amplification attack text (#1895)

martinduke <notifications@github.com> Wed, 24 October 2018 21:36 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 70E15126CC7 for <quic-issues@ietfa.amsl.com>; Wed, 24 Oct 2018 14:36:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DKtkn8dlOqLp for <quic-issues@ietfa.amsl.com>; Wed, 24 Oct 2018 14:36:06 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BD5D712008A for <quic-issues@ietf.org>; Wed, 24 Oct 2018 14:36:05 -0700 (PDT)
Date: Wed, 24 Oct 2018 14:36:04 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540416964; bh=9JOmgoyqvFhIhnyBqraJua5leoj2PVsTnxb+s5BIAa4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=buujb/GcIeolhsDaWm0bUftSRV5rNQXa4wJeXsl4QOuQMM9hU86oL9jCkapo0ednp Nrf0Kz0TpfjOWdmQenwn/aGg+JpWlMYoXWFQtffzP10ZykYbmZij71zkcm6zOUMS7H zNYMGu5Kgn8NLtgX7PBD36A+XJQ+RZlS/2nU9zKU=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abaf78e2f12ec3150dddece183d46555879d1b9aba92cf0000000117e8a7c492a169ce162e64dc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1895/review/168130844@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1895@github.com>
References: <quicwg/base-drafts/pull/1895@github.com>
Subject: Re: [quicwg/base-drafts] Minor edits to amplification attack text (#1895)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd0e5c466719_30683fbf67ed45c013448c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/agKyCX0F9PsDNOjdJyDRw-HT_zM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2018 21:36:08 -0000

martinduke commented on this pull request.



> @@ -1194,13 +1194,14 @@ server then needs to validate that the client owns the address that it claims.
 QUIC therefore performs source address validation during connection
 establishment.
 
-Servers MUST NOT send more than three times as many bytes as the number of bytes
-received prior to verifying the client's address.  Source addresses can be
+Prior to verifying the client's address, servers MUST NOT send more than three

"prior to verifying the client's address" could be construed as modifying "bytes received". When I remove all context for what I know about this, that's how I read the sentence. A new reader would have to reason a bit to understand what you mean, IMO.

if you're neutral I'll stick with it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1895#discussion_r227968818

v2.35.0 | Report a Bug | By Email | System Status