Re: [quicwg/base-drafts] Describe what happens if TLS breaks (#3587)

ianswett <notifications@github.com> Tue, 21 April 2020 02:21 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2A5583A15AF for <quic-issues@ietfa.amsl.com>; Mon, 20 Apr 2020 19:21:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.082
X-Spam-Level:
X-Spam-Status: No, score=0.082 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.282, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wRawUoV8XfMT for <quic-issues@ietfa.amsl.com>; Mon, 20 Apr 2020 19:21:25 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A73F23A1593 for <quic-issues@ietf.org>; Mon, 20 Apr 2020 19:21:25 -0700 (PDT)
Received: from github-lowworker-e8b54ca.ac4-iad.github.net (github-lowworker-e8b54ca.ac4-iad.github.net [10.52.23.39]) by smtp.github.com (Postfix) with ESMTP id C48D15206CC for <quic-issues@ietf.org>; Mon, 20 Apr 2020 19:21:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1587435684; bh=9d8blNi1lRDocfq63x7zS9QO6t6rhrMUO6B2cQNWDf8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=fcmnG9viC3Z5nexTE6/zhaOqSPoVcL8cUKEbRjY5SwUZfd5ytYDWwajKAAEHaaw6W vCaJiFzcCZcNGFrbG0CmdQjJByns7e+Zjwei0cHubCNESR9f1Ymeyymch7Bh8BrIMa yOax9n5+Dqf6FHOwrrqUJNKaxl4qcLURwCaDx3qs=
Date: Mon, 20 Apr 2020 19:21:24 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6WYJ7OUEWD76AAMRF4VI42JEVBNHHCH4FIHU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3587/review/396941715@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3587@github.com>
References: <quicwg/base-drafts/pull/3587@github.com>
Subject: Re: [quicwg/base-drafts] Describe what happens if TLS breaks (#3587)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e9e58a4b3dab_1bbc3f978bccd960243586"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ak208kQrlllMJiawyM8NhS5HY0E>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Apr 2020 02:21:36 -0000

@ianswett approved this pull request.



> @@ -6170,10 +6170,22 @@ considered separately.
 ### Handshake {#handshake-properties}
 
 The QUIC handshake incorporates the TLS 1.3 handshake and enjoys the

enjoys is an odd word to me, but I'm struggling to find a better one.

>  
-In addition to those properties, the handshake is intended to provide some
-defense against DoS attacks on the handshake, as described below.
+Any attack on the TLS handshake that might compromise the secrecy or uniqueness

```suggestion
Any attack on the TLS handshake that compromises the secrecy or uniqueness
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3587#pullrequestreview-396941715