Re: [quicwg/base-drafts] don't allow 0 as a packet number (#832)

Martin Thomson <notifications@github.com> Thu, 19 October 2017 08:35 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 45AA513475C for <quic-issues@ietfa.amsl.com>; Thu, 19 Oct 2017 01:35:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.616
X-Spam-Level:
X-Spam-Status: No, score=-0.616 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RgaN7C160p5C for <quic-issues@ietfa.amsl.com>; Thu, 19 Oct 2017 01:35:34 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A305413473D for <quic-issues@ietf.org>; Thu, 19 Oct 2017 01:35:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=bTHDJvDtCR3bwoGfxo2mNPBhPrU=; b=SIDjwW1DfPmGX9QB NVxrQ15avrPTgiGWahOlYWkY8ve4NSHHDQSQNVArBibDmwgCQ2yjn738StubYggL Mlq2o4ETnftMt4qAuPmW+NGP7aslMsGPQO0u4/xq3LFcOaXisI+2QUPVes54GVrs 9fDbRHl2ocma2jQ0xBRFd3ob5Jw=
Received: by filter0129p1iad2.sendgrid.net with SMTP id filter0129p1iad2-1515-59E863C2-17 2017-10-19 08:35:14.549781595 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0011p1iad2.sendgrid.net (SG) with ESMTP id j8ltUlXeSF247RK7azjY3Q for <quic-issues@ietf.org>; Thu, 19 Oct 2017 08:35:14.557 +0000 (UTC)
Date: Thu, 19 Oct 2017 08:35:14 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab689f22f8b940de9ddca594d019f93681b54448cf92cf00000001160025c292a169ce0fa74d75@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/832/337838510@github.com>
In-Reply-To: <quicwg/base-drafts/issues/832@github.com>
References: <quicwg/base-drafts/issues/832@github.com>
Subject: Re: [quicwg/base-drafts] don't allow 0 as a packet number (#832)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59e863c270960_59213fcfae548f2c76796"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2QFKHJJMJTVYsne9XpNMbVc/Da4qmoIUxp9h MGuq9XU7CIjVFGaveeKV34WlW9oYE3DBNdWVqmFV/zXwHh4tj2Br+blqPVS4JCQBOPzAkGdQ2EP3v4 F8MsLHUJt3ZdhyHo724M2OqgW//YT6xtNcOVsbuAQ9P5pFyuirIhU3TFbqxwhf4bGyuL7sV66gq30r M=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ak3zd4MWPifGqQ9py7TpcAbk-d0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Oct 2017 08:35:36 -0000

The packet number is input to the AEAD nonce.  If you wrap around, you use the same nonce twice.  That's basically fatal for the ciphers we use.  We could allow a wrap around, maintain a counter on each wrap around and concatenate the two, but these are really big numbers and maybe it's not worth it.  You would also need to rekey many times with some ciphers (AES) or the cipher essentially wears out.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/832#issuecomment-337838510