Re: [quicwg/base-drafts] Clarify QPACK eviction races (#1237)
afrind <notifications@github.com> Tue, 28 August 2018 23:52 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AD1C7130E26 for <quic-issues@ietfa.amsl.com>; Tue, 28 Aug 2018 16:52:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qJJ6VwuAF1Dr for <quic-issues@ietfa.amsl.com>; Tue, 28 Aug 2018 16:52:52 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CE21A130E1C for <quic-issues@ietf.org>; Tue, 28 Aug 2018 16:52:51 -0700 (PDT)
Date: Tue, 28 Aug 2018 16:52:50 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1535500370; bh=UOZnts4WOBuCb5iTJXII3pvU5XLMHdUn6AfknfIT7mM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=YP4vchXwBhujIBx2dSvp8cu8kZr3Hyc75g5cap0UoNsLHGYQLZaRF7VD76gE+RreF a1ITmGAsaKXm/sgzpBzovMIDbHZguzSAvr3t1Jlnh4yFtqRgFr051IW1CaG1nvVVIb lFyWGXlPDR+S4Hzzm7FTsw+aD7khCS6ECSGs2Bvg=
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd1fd0d19a46412c538bba71eb29baaecf1e6e35292cf00000001179da25292a169ce12443a1c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1237/review/150359361@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1237@github.com>
References: <quicwg/base-drafts/pull/1237@github.com>
Subject: Re: [quicwg/base-drafts] Clarify QPACK eviction races (#1237)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b85e0529c2c2_8743fdb080d45bc196810"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/akI8fKuFpWvI8e_1wVDF5_9mYD0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Aug 2018 23:52:54 -0000
afrind commented on this pull request.
> +any eviction-prone entries, which are dynamic table entries that might be
+evicted soon. Rather than reference an eviction-prone entry, the encoder SHOULD
+emit an Indexed-Duplicate representation (see {{indexed-duplicate}}), and
+reference the duplicate instead.
+
+To identify eviction-prone entries, the encoder can maintain a draining index,
+which is the smallest absolute index in the dynamic table that it will emit a
+reference for. As new entries are inserted, the encoder increments the
+draining index such that the amount of free and draining space in the dyanmic
+table is larger than its target threshold.
+
+~~~~~~~~~~ drawing
+ +----------------+-----------------------+------------+
+ | Eviction-prone | Referenceable | Free Space |
+ | Entries | Entries | |
+ +----------------+-----------------------+------------+
I'm not sure I agree that the draining index always needs to be in the acknowledged range. Consider the case where I insert a full table's worth of headers and none have yet been acknowledged. An encoder will still want to stop referencing the oldest ones so they can be evicted soon, even if it causes duplication. For the purposes of this section, I'm not sure I want to add the 'acknowledged index' to the picture.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1237#discussion_r213507920
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Mike Bishop
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- [quicwg/base-drafts] Clarify QPACK eviction races… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Mike Bishop
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Mike Bishop
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Mike Bishop
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind