IETF Logo Mail Archive

Re: [quicwg/base-drafts] SetLossDetectionTime negative timeout (#2052)

Martin Thomson <notifications@github.com> Wed, 28 November 2018 02:21 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9C6BF130E91 for <quic-issues@ietfa.amsl.com>; Tue, 27 Nov 2018 18:21:54 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JL75oqFgyRRy for <quic-issues@ietfa.amsl.com>; Tue, 27 Nov 2018 18:21:53 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2311C130E27 for <quic-issues@ietf.org>; Tue, 27 Nov 2018 18:21:53 -0800 (PST)
Date: Tue, 27 Nov 2018 18:21:52 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543371712; bh=rArZc/mppPyNI/xj5u2IW6Rg2Z13jVYyoko2n48X4dY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=m7Q0P0VCyUi4GPchcfAGjO24xGWoODk+fUoqV2toNS8V3ZHvND3pExff83EN51rvs /mQ4fyIq65tT5E3BGvN2XtgboJq7eF10NKtzeKFNBtJnKuEvlSi73oMBJHmPAuwgmd 0FAVysR7P0imK5fM6ijLaRslq89Sdt2PxLgzGWSk=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab1a094a3cc643121263ee70ae84ec39b9517c122792cf000000011815bdc092a169ce16e756f7@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2052/442293982@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2052@github.com>
References: <quicwg/base-drafts/issues/2052@github.com>
Subject: Re: [quicwg/base-drafts] SetLossDetectionTime negative timeout (#2052)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bfdfbc01fe0f_2daf3fb9a22d45c4103338"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/arcISCks6-6K3ztNQ7za_0i4MsQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Nov 2018 02:21:55 -0000

I think that Kazuho is right.  `timeout = max(timeout, 0)` isn't that hard to add to the algorithm.  An unchecked underflow on an unsigned integer would be an unfortunate outcome.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2052#issuecomment-442293982

v2.29.0 | Report a Bug | By Email | System Status