Re: [quicwg/base-drafts] Proposed change to #1965 (#2212)
janaiyengar <notifications@github.com> Thu, 20 December 2018 05:40 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A94E8130FFB for <quic-issues@ietfa.amsl.com>; Wed, 19 Dec 2018 21:40:40 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.065
X-Spam-Level:
X-Spam-Status: No, score=-8.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WPSB8PXlUnvo for <quic-issues@ietfa.amsl.com>; Wed, 19 Dec 2018 21:40:39 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DAD08130FF8 for <quic-issues@ietf.org>; Wed, 19 Dec 2018 21:40:38 -0800 (PST)
Date: Wed, 19 Dec 2018 21:40:36 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545284436; bh=kufMy8/XIesSv5nmcEQTwWCywsQmeSFJWH/h8BZxCRg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=07zgqS1LBkfji/xqFxGHPSsiRwGvZQcWaFir2kLWxRcNamRnu3fG+MhUhBsrByWtq 9ymaJM5td+/t3c7T9T2e2Mv4oeXhausqvhg0yBoS/9qJapViCBWHd+HQDlnJYfltor sklA59BCG7WB2TEqzfmnrDLelmkEF9rE9uRIkAxs=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3e9366bd73b94e27f857232bc0e16524b84874a892cf000000011832ed5492a169ce176a63e1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2212/c448880337@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2212@github.com>
References: <quicwg/base-drafts/pull/2212@github.com>
Subject: Re: [quicwg/base-drafts] Proposed change to #1965 (#2212)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1b2b54cbe63_302d3f95152d45bc7617d1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/arrcjZPSH7H9KZsRfW9O8js9LvQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Dec 2018 05:40:41 -0000
@martinduke : This PR has the outcome you are looking for. Basically, on a PTO, if you have something to retransmit, you will. If you have nothing to retransmit, Ian's PR suggests that you basically send a PING to elicit an ACK. This PR calls them lost instead, so inflight is down to 0 immediately (if inflight is down to 0, you are not blocked anymore when you need to send new app data).
Basically, this PR says:
```
if (new or unacked data available)
send it in a new packet
else
mark unacked data as lost (give up on this data)
```
At the end, you either have a packet in flight (and a PTO armed), or you have nothing in flight (and no PTO armed). The point is that you don't need to send anything if you don't have anything to send. You mark what was inflight as lost because it's actually reasonable to do so (it's been long enough).
In terms of #2103 , let's have that discussion there. I don't think there's conceptual muddling here. It's possible that I'm missing it entirely, but I don't see the muddle (yet :-)).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2212#issuecomment-448880337
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- [quicwg/base-drafts] Proposed change to #1965 (#2… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… Nick Banks
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… martinduke
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… martinduke
- Re: [quicwg/base-drafts] Proposed change to #1965… martinduke
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… Kazuho Oku
- Re: [quicwg/base-drafts] Proposed change to #1965… MikkelFJ
- Re: [quicwg/base-drafts] Proposed change to #1965… MikkelFJ
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… Martin Thomson