Re: [quicwg/base-drafts] Tighten HEADERS and DATA frame order requirements. (#2867)

Bence Béky <notifications@github.com> Wed, 17 July 2019 14:14 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CF2491206B2 for <quic-issues@ietfa.amsl.com>; Wed, 17 Jul 2019 07:14:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.381
X-Spam-Level:
X-Spam-Status: No, score=-6.381 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.001, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yNP2vjmtUo1p for <quic-issues@ietfa.amsl.com>; Wed, 17 Jul 2019 07:14:50 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 44E9C1206C0 for <quic-issues@ietf.org>; Wed, 17 Jul 2019 07:14:42 -0700 (PDT)
Date: Wed, 17 Jul 2019 07:14:41 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1563372881; bh=0g1u2Cq5zPQ7U+kFDCGp2/cCk+kq0VMwphdtVmFHtbM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=EwcuW8C6XzpIX1TXGyJkhL4wA/ZFktVs2ISAyAlZVefNtyz0sB1pvTzDz94lkNnFU rJqdre0Of/R7jnhEGg7Af/7aBgiE8jGv9NC0znqXQ/zFHm5cj/zBv/qFeR8iJZ4+qv yPyU5Ll7NiM0kwkzoKRP23iZ06jrRGcUIq3FT8C0=
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7YLTTOM2I5NWM67D53HRP5DEVBNHHBXHO4II@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2867/c512273416@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2867@github.com>
References: <quicwg/base-drafts/pull/2867@github.com>
Subject: Re: [quicwg/base-drafts] Tighten HEADERS and DATA frame order requirements. (#2867)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d2f2d5157a5e_36cd3ff09bccd9601603e2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/b0jvJV92twOzX9UsoAjsnUEC0DM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jul 2019 14:14:52 -0000

> This text was already somewhat lacking by not discussing the possibility of extension frames being interleaved; stating that the push stream consists of "responses" rather than "frames" extends this shortcoming to the push stream section.
> 
> I'm open to fixing this in a separate PR, if you prefer, though.

Good catch.  I added a paragraph to explicitly allow unknown frames to the message exchange section.  I also modified the wording in the push section to be more permissive of interleaved frames ("by" instead of "consists of").

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2867#issuecomment-512273416