Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rather than CRYPTO_CLOSE (#1477)
Martin Thomson <notifications@github.com> Tue, 26 June 2018 05:03 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 703C0130E9B for <quic-issues@ietfa.amsl.com>; Mon, 25 Jun 2018 22:03:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PqI-MiGocdph for <quic-issues@ietfa.amsl.com>; Mon, 25 Jun 2018 22:03:12 -0700 (PDT)
Received: from out-12.smtp.github.com (out-12.smtp.github.com [192.30.254.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4BA4D130EBA for <quic-issues@ietf.org>; Mon, 25 Jun 2018 22:03:12 -0700 (PDT)
Date: Mon, 25 Jun 2018 22:03:11 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1529989391; bh=70KEUtjgY17wWKrnri6yNqLTSba+lS/clYxT3CnsCsI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=DjfDCJDs/R4syQ8DPmNLvnsfRzRfbyEcZeYqh0gT3ozzUQ1PyJRyhqI4BW8LjvUTz /ksZmRuGNRf86pBPbodBQ/wucke6dFc03qd78P+Fwwd6TR6R/AWxgjsmM55J9YNwIs XL8HAXKpSaePe1AnsexwGJ4GJmCWzX3w0m1TOhBU=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8df07a70b5d13420c1c2efd24e4afd7d60e83c8092cf0000000117498b0f92a169ce14014295@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1477/review/131865450@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1477@github.com>
References: <quicwg/base-drafts/pull/1477@github.com>
Subject: Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rather than CRYPTO_CLOSE (#1477)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b31c90f8ccc8_7e6b2abbd7776f6027993"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/b2cqai4uXb4lVftN-aO3rgLUghI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jun 2018 05:03:15 -0000
martinthomson commented on this pull request. > @@ -602,10 +602,16 @@ HelloRetryRequest is still used for incorrect key shares. ## TLS Errors -If TLS experiences an error, it MUST generate an appropriate alert -as defined in {{TLS13}}; Section 6) and then provide it to QUIC, -which sends the alert in a CRYPTO_CLOSE frame. All such alerts are -"fatal" (see {{TLS13}}, Section 6.2. +If TLS experiences an error, it generates an appropriate alert as defined in +Section 6 of {{TLS13}}. + +A TLS alert is turned into a QUIC connection error by converting the alert +description into a QUIC error code. The alert description is added to 0x200 to +produce a QUIC error code from the range reserved for CRYPTO_ERROR. The +resulting value is sent in a QUIC CONNECTION_CLOSE frame. + +The alert level of all TLS alerts is "fatal", a TLS stack does not generate +alerts at the "warning" level. I thought that this was OK. TLS 1.3 prohibits use of warning for anything but close_notify, and we don't allow TLS to close. I guess that MUST NOT isn't a problem though. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1477#discussion_r198014372
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… Martin Thomson
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… Martin Thomson
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… Martin Thomson
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… Martin Thomson
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… Mike Bishop
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… janaiyengar
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… Nick Banks
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… ianswett
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… Rui Paulo
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… Martin Thomson
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… Martin Thomson
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… ekr
- [quicwg/base-drafts] Use CONNECTION_CLOSE rather … Martin Thomson