Re: [quicwg/base-drafts] Why are there two ways of associating push with requests? (#3275)

Lucas Pardue <notifications@github.com> Wed, 04 December 2019 14:05 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F3351120813 for <quic-issues@ietfa.amsl.com>; Wed, 4 Dec 2019 06:05:48 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CyTKu2yeO9R2 for <quic-issues@ietfa.amsl.com>; Wed, 4 Dec 2019 06:05:47 -0800 (PST)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 960D812012E for <quic-issues@ietf.org>; Wed, 4 Dec 2019 06:05:47 -0800 (PST)
Date: Wed, 04 Dec 2019 06:05:46 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1575468346; bh=/j/mGarmicqTrjwXK856KxOp6Wie+4J/wfzeFo8qSmU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=DS4b8aZNx+Alz26tVDksGbM8K1OVTvunrBv3s2x3b0hu1+/UTpuUnYa8zSl0PAmDF 99MC7MgEf28OlCJEFzwyN7YHgdoJ2F4q2CjYowOTH80ChUjiuYp4g0ENKPNdHkkLdE pf5zaDoja5cLXE/nJ0SKyOCZwmykfwgaGm7Fs1j4=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4MZXDATO634VWMJV536TX3VEVBNHHB7DC6LI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3275/561659879@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3275@github.com>
References: <quicwg/base-drafts/issues/3275@github.com>
Subject: Re: [quicwg/base-drafts] Why are there two ways of associating push with requests? (#3275)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5de7bd3a8e2bb_1b863f9702ecd9603799d1"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/b3JaKDBktAMwlTn96hjsL5-qXRM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Dec 2019 14:05:49 -0000

> I'd suggest removing DUPLICATE_PUSH and allowing duplicate PUSH_PROMISE frames on different response streams.
> DUPLICATE_PUSH saves a few bytes over an equivalent PUSH_PROMISE, but I believe has no value.

What we have now addresses a specific concern raised on #1864 about how to handle multiple PUSH_PROMISES with the same ID. Mike suggested some points that could be address on that ticket https://github.com/quicwg/base-drafts/issues/1864#issuecomment-430697483 if we continued to allow multiple PUSH_PROMISE:

>     * Maintains a list of active promises for which it is still willing to accept an additional reference to the promise, including the uncompressed headers for the promise (likely until the promise is fulfilled, possibly plus a timeout)
>     * Verifies that the headers match exactly when receiving an additional reference to one of these promises; MUST error if they don't.
>     * If a promise is received for an ID which has already been flushed from the list, the promise is ignored

A PR that proposes removing DUPLICATE_PUSH should address the above.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3275#issuecomment-561659879