Date: Tue, 26 May 2020 22:58:22 -0700
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK7VRXOY422YKBUMO3F43HRH5EVBNHHCKEI7XY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3681/review/418844024@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3681@github.com>
References: <quicwg/base-drafts/pull/3681@github.com>
Subject: Re: [quicwg/base-drafts] Split PTO calculation into a dedicated
 method (#3681)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5ece017efb31_28cf3ff5deccd9686593bf";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/b46FeQxZkB52FAWbsCqHPy3FM4A>


----==_mimepart_5ece017efb31_28cf3ff5deccd9686593bf
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@marten-seemann requested changes on this pull request.



>        space = pn_space
   return time, space
 
+GetPtoTimeAndSpace():
+  duration = smoothed_rtt +
+      max(4 * rttvar, kGranularity) * (2 ^ pto_count)

I believe you're missing a pair of brackets here.

>        space = pn_space
   return time, space
 
+GetPtoTimeAndSpace():
+  duration = smoothed_rtt +
+      max(4 * rttvar, kGranularity) * (2 ^ pto_count)
+  # Arm PTO from now when there are no inflight packets
+  if (no in-flight packets):
+    return (now() + duration), Initial

This breaks the following case: As a client, I need to send a Handshake packet to unblock the server's amplification limit, if the Initial packet number space was already dropped.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3681#pullrequestreview-418844024
----==_mimepart_5ece017efb31_28cf3ff5deccd9686593bf
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p></p>
<p><b>@marten-seemann</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3681#discussion_r430846580">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt;        space = pn_space
   return time, space
 
+GetPtoTimeAndSpace():
+  duration = smoothed_rtt +
+      max(4 * rttvar, kGranularity) * (2 ^ pto_count)
</pre>
<p>I believe you're missing a pair of brackets here.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3681#discussion_r430873809">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt;        space = pn_space
   return time, space
 
+GetPtoTimeAndSpace():
+  duration = smoothed_rtt +
+      max(4 * rttvar, kGranularity) * (2 ^ pto_count)
+  # Arm PTO from now when there are no inflight packets
+  if (no in-flight packets):
+    return (now() + duration), Initial
</pre>
<p>This breaks the following case: As a client, I need to send a Handshake packet to unblock the server's amplification limit, if the Initial packet number space was already dropped.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3681#pullrequestreview-418844024">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK6FUNO5C3CTSLS6J3LRTSTX5ANCNFSM4NGCCLSA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK5V3DZ6I75BVYMXEMTRTSTX5A5CNFSM4NGCCLSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODD3Q26A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3681#pullrequestreview-418844024",
"url": "https://github.com/quicwg/base-drafts/pull/3681#pullrequestreview-418844024",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5ece017efb31_28cf3ff5deccd9686593bf--