IETF Logo Mail Archive

Re: [quicwg/base-drafts] Split PTO calculation into a dedicated method (#3681)

Jana Iyengar <notifications@github.com> Sun, 31 May 2020 02:11 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AE0243A10D1 for <quic-issues@ietfa.amsl.com>; Sat, 30 May 2020 19:11:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wLT1cbgWFcz9 for <quic-issues@ietfa.amsl.com>; Sat, 30 May 2020 19:11:45 -0700 (PDT)
Received: from out-26.smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7EF3C3A10D0 for <quic-issues@ietf.org>; Sat, 30 May 2020 19:11:45 -0700 (PDT)
Received: from github-lowworker-cde56e0.va3-iad.github.net (github-lowworker-cde56e0.va3-iad.github.net [10.48.25.52]) by smtp.github.com (Postfix) with ESMTP id 98DE3281786 for <quic-issues@ietf.org>; Sat, 30 May 2020 19:11:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1590891104; bh=1Ap8l5WLgHXHdvh6yYnA3iAVVnOOc00g2JJEnyyFmyU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SZZGKJrEpYcOuv0Ulo2y3nkC6Kq6wNf6dg01Z953ytITYH8az3FtCvF9b7uPj//O5 eqQJjIye8Khxja3nXW9Uw1ylnd6gRUgFQCzqHAQ330lESSHgJExV9iCLeMWIq1mTW7 Y7hvQox0c978FGgiDNkc+GonDTUxSQBORLPg7/eU=
Date: Sat, 30 May 2020 19:11:44 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4IXPKJ2GEFJ35VZJ5433ZWBEVBNHHCKEI7XY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3681/review/421455914@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3681@github.com>
References: <quicwg/base-drafts/pull/3681@github.com>
Subject: Re: [quicwg/base-drafts] Split PTO calculation into a dedicated method (#3681)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ed31260887b6_75873f80014cd9641010125"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/b9nlZAfiAYSWn0M04gs7DsC1xQI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 31 May 2020 02:11:47 -0000

@janaiyengar commented on this pull request.



>        space = pn_space
   return time, space
 
+GetPtoTimeAndSpace():
+  duration = (smoothed_rtt + max(4 * rttvar, kGranularity))
+      * (2 ^ pto_count)
+  # Arm PTO from now when there are no inflight packets
+  if (no in-flight packets):

never mind, I thought the code below to do the early return when no packets are in flight after address validation was removed. It's still there, so all good.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3681#discussion_r432902747

v2.23.0 | Report a Bug | By Email