Re: [quicwg/base-drafts] QPACK Auth48 edits (PR #4982)

[Mike Bishop <[e-mail]>]

@MikeBishop commented on this pull request.



> @@ -657,14 +640,14 @@ HPACK defines string literals to begin on a byte boundary.  They begin with a
 single bit flag, denoted as 'H' in this document (indicating whether the string
 is Huffman-coded), followed by the Length encoded as a 7-bit prefix integer, and
 finally Length bytes of data. When Huffman encoding is enabled, the Huffman
-table from {{Section B of RFC7541}} is used without modification and Length
+table from {{Section B of RFC7541}} is used without modification, and Length

```suggestion
table from {{Section B of RFC7541}} is used without modification and Length
```
Since the Huffman table isn't a parenthetical phrase, I'm not sure adding this comma makes sense.

> @@ -928,9 +911,9 @@ The encoder transforms the Required Insert Count as follows before encoding:
 
 Here `MaxEntries` is the maximum number of entries that the dynamic table can

On lines 912-920, the RFC Editor text output does not have quotes, but (as with the HTTP/3 AUTH48) this appears to be a tooling difference rather than a deliberate change.  The XML matches.

>  individual characters. An attacker can only learn whether a guess is correct or
-not, so is reduced to a brute force guess for the field values associated with a
-given field name.
+not, so it is reduced to a brute-force guess for the field values associated

```suggestion
not, so the attacker is reduced to a brute-force guess for the field values associated
```
The suggested "it" is ambiguous between the attacker and the guess.

> @@ -1395,7 +1378,7 @@ immediately sent due to flow control is not affected by this limit.
 Implementations should limit the size of unsent data, especially on the decoder
 stream where flexibility to choose what to send is limited.  Possible responses
 to an excess of unsent data might include limiting the ability of the peer to
-open new streams, reading only from the encoder stream, or closing the
+open new streams, reading only from the encoder stream or closing the

```suggestion
open new streams, reading only from the encoder stream, or closing the
```
This is a list of three possible mitigations; I believe the Oxford comma is appropriate.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4982#pullrequestreview-930973915
You are receiving this because you are subscribed to this thread.

Message ID: <quicwg/base-drafts/pull/4982/review/[e-mail]>