IETF Logo Mail Archive

Re: [quicwg/base-drafts] Don't arm the handshake timer if there's no data (#2590)

Benjamin Saunders <notifications@github.com> Fri, 12 April 2019 00:34 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6A31F120337 for <quic-issues@ietfa.amsl.com>; Thu, 11 Apr 2019 17:34:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.598
X-Spam-Level:
X-Spam-Status: No, score=-6.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9s42JECOhYf3 for <quic-issues@ietfa.amsl.com>; Thu, 11 Apr 2019 17:34:25 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DD7D512010D for <quic-issues@ietf.org>; Thu, 11 Apr 2019 17:34:24 -0700 (PDT)
Date: Thu, 11 Apr 2019 17:34:23 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555029263; bh=Jo751OUoTl4qgAU4+gwmCtCYa587ml10I6YhUx+CQcg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=lFiD4EjjnuX02cLEcZ2NKwbRo54TNnK7X/yehvHBtKmtgtF3q6icptptDwcUqbiaR Gfm6xdPFtFKHL54sNUxK7jGmkG8p2kP0GLZSWMyw3K1/2KQV/P0Cv/FzwKggwE8Ech L6s54CDwdf+uYuZVeuVzJZkVwaay7iEBBEl08MCY=
From: Benjamin Saunders <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab27a7ac95a4608fc1dce3f423a22a9950fdb4368a92cebabd0f8f92a169ce199da23e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2590/review/225855470@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2590@github.com>
References: <quicwg/base-drafts/pull/2590@github.com>
Subject: Re: [quicwg/base-drafts] Don't arm the handshake timer if there's no data (#2590)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cafdd0fb0a46_61803fa8b28d45c4137373"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: Ralith
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/bEUy66bh1dw3qeRf-w_W3ECJq9o>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Apr 2019 00:34:27 -0000

Ralith commented on this pull request.



> @@ -1151,7 +1158,8 @@ OnLossDetectionTimeout():
     DetectLostPackets(pn_space)
   // Retransmit crypto data if no packets were lost
   // and there are still crypto packets in flight.
-  else if (crypto packets are in flight):
+  else if (crypto packets are in flight &&
+           crypto data to send):

I agree that this wording is confusing; in particular, it's not obvious that "to send" means "not yet acknowledged," except perhaps by process of elimination.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2590#discussion_r274726184

v2.23.0 | Report a Bug | By Email