Re: [quicwg/base-drafts] Split minimum idle timeout period (#3847)

ekr <notifications@github.com> Wed, 08 July 2020 01:52 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A996B3A11E0 for <quic-issues@ietfa.amsl.com>; Tue, 7 Jul 2020 18:52:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tBqz5u1ERWUO for <quic-issues@ietfa.amsl.com>; Tue, 7 Jul 2020 18:52:56 -0700 (PDT)
Received: from out-26.smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B5A303A0DE0 for <quic-issues@ietf.org>; Tue, 7 Jul 2020 18:52:55 -0700 (PDT)
Received: from github-lowworker-0f7e7fd.ash1-iad.github.net (github-lowworker-0f7e7fd.ash1-iad.github.net [10.56.110.17]) by smtp.github.com (Postfix) with ESMTP id E21F3282817 for <quic-issues@ietf.org>; Tue, 7 Jul 2020 18:52:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1594173174; bh=8VjpaR7FHbw6S7qCn/mafL0iSqkqOlJ6xYVvVZ7WyjA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=kg8pSFYCbLBhnUJQBJRcHQjqVFJVLOvfStZ2fsYxgEzauSs0/mROrm/9bx26ZzPTu 91P89QoHm2TeNaP6XlOAN8VMOfOKBu/MYrOAS6BXznCH/TdDor+KMO/zKCPhvSAeVC 9mS6EfdMR9/43Cg7mECBhWgtGc7lueRx6/ksVKwg=
Date: Tue, 07 Jul 2020 18:52:54 -0700
From: ekr <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5WLGZHJJGALQ6E7755CED7NEVBNHHCN2KSQE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3847/review/444359904@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3847@github.com>
References: <quicwg/base-drafts/pull/3847@github.com>
Subject: Re: [quicwg/base-drafts] Split minimum idle timeout period (#3847)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f0526f6d214c_79cc3feed28cd95c663de"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ekr
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/bHsRn1ZAzpalT_fh9d78d_t9TYQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jul 2020 01:53:04 -0000

@ekr commented on this pull request.



> @@ -2682,6 +2681,10 @@ ack-eliciting packet if no other ack-eliciting packets have been sent since last
 receiving and processing a packet. Restarting this timer when sending a packet
 ensures that connections are not closed after new activity is initiated.
 
+There is no minimum value for max_idle_timeout.  To avoid excessively small idle

This is like a major nitpick, but isn't the minimum value actually 1ms, because 0 means no timeout?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3847#pullrequestreview-444359904