Date: Thu, 17 Jan 2019 01:46:50 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4aba69a333d671568ab4bb436827fba52064f400aea92cf000000011858110a92a169ce17d8cc13@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2340/review/193534236@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2340@github.com>
References: <quicwg/base-drafts/pull/2340@github.com>
Subject: Re: [quicwg/base-drafts] Add note about frequent RTT estimates (#2340)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5c404f0addaeb_2e113fa7906d45bc24251c";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/bIDyWPymqYArpTT2W1oXNLcDUfg>


----==_mimepart_5c404f0addaeb_2e113fa7906d45bc24251c
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett commented on this pull request.



> @@ -292,6 +292,10 @@ ack delay field should be ignored.
 Like TCP, QUIC calculates both smoothed RTT and RTT variance similar to those
 specified in {{?RFC6298}}.
 
+A sender might take multiple samples per RTT, and as suggested in {{?RFC6298}},

```suggestion
Taking a sample from every ACK with a larger largest acked is likely to cause a sender to take multiple samples per RTT, and as suggested in {{?RFC6298}},
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2340#pullrequestreview-193534236
----==_mimepart_5c404f0addaeb_2e113fa7906d45bc24251c
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p><b>@ianswett</b> commented on this pull request.</p>=0D
=0D
<hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/2340#discussi=
on_r248600261">draft-ietf-quic-recovery.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; @@ -292,6 +292,10 @@ ack delay field shoul=
d be ignored.=0D
 Like TCP, QUIC calculates both smoothed RTT and RTT variance similar to =
those=0D
 specified in {{?RFC6298}}.=0D
 =0D
+A sender might take multiple samples per RTT, and as suggested in {{?RFC=
6298}},=0D
</pre>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-A sender might take multiple samples per RTT,=
 and as suggested in {{?RFC6298}},=0D
+Taking a sample from every ACK with a larger largest acked is likely to =
cause a sender to take multiple samples per RTT, and as suggested in {{?R=
FC6298}},=0D
</pre>=0D
=0D
=0D
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/2340#pullrequestreview-193534236">view it on GitHub</=
a>, or <a href=3D"https://github.com/notifications/unsubscribe-auth/AWbkq=
453SVKdTLjhHSTJVbakoXxdECl4ks5vEEaKgaJpZM4aEVlj">mute the thread</a>.<img=
 src=3D"https://github.com/notifications/beacon/AWbkq6mGsn74YfS8nk34oV4ZH=
_PhvAkRks5vEEaKgaJpZM4aEVlj.gif" height=3D"1" width=3D"1" alt=3D"" /></p>=
=0D
<script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_versio=
n":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name"=
:"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"=
quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"http=
s://github.githubassets.com/images/email/message_cards/header.png","avata=
r_image_url":"https://github.githubassets.com/images/email/message_cards/=
avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/q=
uicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@=
ianswett commented on #2340"}],"action":{"name":"View Pull Request","url"=
:"https://github.com/quicwg/base-drafts/pull/2340#pullrequestreview-19353=
4236"}}}</script>=0D
<script type=3D"application/ld+json">[=0D
{=0D
"@context": "http://schema.org",=0D
"@type": "EmailMessage",=0D
"potentialAction": {=0D
"@type": "ViewAction",=0D
"target": "https://github.com/quicwg/base-drafts/pull/2340#pullrequestrev=
iew-193534236",=0D
"url": "https://github.com/quicwg/base-drafts/pull/2340#pullrequestreview=
-193534236",=0D
"name": "View Pull Request"=0D
},=0D
"description": "View this Pull Request on GitHub",=0D
"publisher": {=0D
"@type": "Organization",=0D
"name": "GitHub",=0D
"url": "https://github.com"=0D
}=0D
}=0D
]</script>=

----==_mimepart_5c404f0addaeb_2e113fa7906d45bc24251c--