Re: [quicwg/base-drafts] One close frames (#1900)
Martin Thomson <notifications@github.com> Tue, 30 October 2018 01:00 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6DC1C1288BD for <quic-issues@ietfa.amsl.com>; Mon, 29 Oct 2018 18:00:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VYvIuIhWXxRp for <quic-issues@ietfa.amsl.com>; Mon, 29 Oct 2018 18:00:05 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1689C12870E for <quic-issues@ietf.org>; Mon, 29 Oct 2018 18:00:05 -0700 (PDT)
Date: Mon, 29 Oct 2018 18:00:04 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540861204; bh=nkpw5zBw1SKBO/1bj+HcgaXorS//p4shFn41ksJct68=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=GSU/AHNEdkwXdIKSzwnA8tQAXyuU8EiOl4KZptiJJo1rzo0bTfr3pgko/S1O7WVFu 5RFVWLZ+5tlUpae0owA48RKoDHQTpVld1lbrHl9v8m72n7r1MoLDzJxTWgjmEX7lW3 03MbX1OLxUGaacG2rUHKnhhMbRhQH/aA05sKloqc=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd42dc36dc9281dc12828f8bf3b598b50b9ddc4db92cf0000000117ef6f1492a169ce164012de@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1900/review/169577509@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1900@github.com>
References: <quicwg/base-drafts/pull/1900@github.com>
Subject: Re: [quicwg/base-drafts] One close frames (#1900)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd7ad1444d31_6d243fc9b4ad45b859753"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/bLT4ad_0FHBgDxrGYiDcA9kL8dg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Oct 2018 01:00:06 -0000
martinthomson commented on this pull request. > @@ -4067,9 +4065,13 @@ Final Offset: ## CONNECTION_CLOSE frame {#frame-connection-close} -An endpoint sends a CONNECTION_CLOSE frame (type=0x02) to notify its peer that -the connection is being closed. CONNECTION_CLOSE is used to signal errors at -the QUIC layer, or the absence of errors (with the NO_ERROR code). +An endpoint sends a CONNECTION_CLOSE frame (type=0x02 or 0x03) to notify its +peer that the connection is being closed. The CONNECTION_CLOSE with a frame +type of 0x02 is used to signal errors at the QUIC layer, or the absence of +errors (with the NO_ERROR code). The CONNECTION_CLOSE frame with a type of 0x03 +is used to signal an error with the protocol that uses QUIC. Protocols that use +QUIC only use the CONNECTION_CLOSE frame of type 0x03; the frame with type 0x02 +is only used internally by QUIC. As I said elsewhere, that's a wash when you try it out. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1900#discussion_r229147216
- [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Kazuho Oku
- Re: [quicwg/base-drafts] One close frames (#1900) MikkelFJ
- Re: [quicwg/base-drafts] One close frames (#1900) ianswett
- Re: [quicwg/base-drafts] One close frames (#1900) ianswett
- Re: [quicwg/base-drafts] One close frames (#1900) MikkelFJ
- Re: [quicwg/base-drafts] One close frames (#1900) ianswett
- Re: [quicwg/base-drafts] One close frames (#1900) ianswett
- Re: [quicwg/base-drafts] One close frames (#1900) Marten Seemann
- Re: [quicwg/base-drafts] One close frames (#1900) Lucas Pardue
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Lucas Pardue
- Re: [quicwg/base-drafts] One close frames (#1900) Nick Banks
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Mike Bishop
- Re: [quicwg/base-drafts] One close frames (#1900) Mike Bishop
- Re: [quicwg/base-drafts] One close frames (#1900) MikkelFJ
- Re: [quicwg/base-drafts] One close frames (#1900) Mike Bishop
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) janaiyengar
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) ianswett
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson