Re: [quicwg/base-drafts] Allow stream-related frames in 0-RTT (#2355)

Alessandro Ghedini <notifications@github.com> Tue, 22 January 2019 11:51 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2C546130ED1 for <quic-issues@ietfa.amsl.com>; Tue, 22 Jan 2019 03:51:32 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.149
X-Spam-Level:
X-Spam-Status: No, score=-11.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DJ64xaQ4ojpZ for <quic-issues@ietfa.amsl.com>; Tue, 22 Jan 2019 03:51:30 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 696FE1228B7 for <quic-issues@ietf.org>; Tue, 22 Jan 2019 03:51:30 -0800 (PST)
Date: Tue, 22 Jan 2019 03:51:29 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1548157889; bh=qUPrPIdH0KOawqLIYYVPTbea7TNgUTWpEvCmwPKW5F0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dCVKw/9JK1t7tdVhfeKegh8pWwj3CczUSqUPmmRxv1pyAivAxrqH4EnqNtJmlEuZx 0bGK008xhuqwbETxpG9sKMMNkv7Y/lVIKr7pDvkef7+OiMZLhXjMl+aITB36JsnfSj rn6ndSm0WO1ib3ImSw9NBRj53R6HtGSCmqDRm5X4=
From: Alessandro Ghedini <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4fb6ece27a041e9c52011b691c98060fd67d7bb592cf00000001185ec5c192a169ce17e9c1c4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2355/review/194965840@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2355@github.com>
References: <quicwg/base-drafts/pull/2355@github.com>
Subject: Re: [quicwg/base-drafts] Allow stream-related frames in 0-RTT (#2355)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c4703c11f451_5d603fa4308d45b4156220"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ghedo
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/bSAXwZIXN8oXm33zGaNjo1nFDM4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jan 2019 11:51:32 -0000

ghedo requested changes on this pull request.



> @@ -326,17 +326,12 @@ encryption levels:
 
 - CRYPTO frames MAY appear in packets of any encryption level except 0-RTT.
 
-- CONNECTION_CLOSE MAY appear in packets of any encryption level other than

Section 10.3 of the transport draft says that if 1-RTT keys are not available, CONNECTION_CLOSE can be sent in Initial and Handshake, but if I read this right, this change means that CONNECTION_CLOSE can only be sent in 1-RTT and 0-RTT?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2355#pullrequestreview-194965840