Re: [quicwg/base-drafts] Add note about frequent RTT estimates (#2340)

janaiyengar <notifications@github.com> Fri, 18 January 2019 01:22 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1F62A12D4F2 for <quic-issues@ietfa.amsl.com>; Thu, 17 Jan 2019 17:22:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.149
X-Spam-Level:
X-Spam-Status: No, score=-11.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cbuqJy7ny9_P for <quic-issues@ietfa.amsl.com>; Thu, 17 Jan 2019 17:22:19 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5880313105F for <quic-issues@ietf.org>; Thu, 17 Jan 2019 17:22:19 -0800 (PST)
Date: Thu, 17 Jan 2019 17:22:18 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1547774538; bh=siPwmFdqfsX5gg5KOFMK2a2tiJlhFYedwGtDc08iSMs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=m31Q2TwdiwBOsY93I+G8Ckq0YjGO+tiiJCrDco5RsGc2PFOzpXfxS44inBMVYkcax OWbHXpkm+Sia4ubsDtD4s+ubRIarb0C/57aUaZNPuh94Swpk2GyZNWybhTuAh7FOVB NoM7nEMDXkWWxuVupV+x1v/hj6UEQkKyrZmjscVU=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab9cbbc38d5672fb10fd58ecbecffa06566f48cec892cf000000011858ec4a92a169ce17d8cc13@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2340/review/193914340@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2340@github.com>
References: <quicwg/base-drafts/pull/2340@github.com>
Subject: Re: [quicwg/base-drafts] Add note about frequent RTT estimates (#2340)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c412a4a545ea_1fef3fef222d45b4175066"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/bXNdc5SGdplm7MUfVOb4AU-LQrw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Jan 2019 01:22:21 -0000

janaiyengar commented on this pull request.



> @@ -289,8 +289,14 @@ be subtracted from the RTT as long as the result is larger than the min_rtt.
 If the result is smaller than the min_rtt, the RTT should be used, but the
 ack delay field should be ignored.
 
-Like TCP, QUIC calculates both smoothed RTT and RTT variance similar to those
-specified in {{?RFC6298}}.
+A sender calculates both smoothed RTT and RTT variance similar to those
+specified in {{?RFC6298}}, see {{on-ack-received}}.
+
+A sender will commonly receive ACK frames that acknowledge larger packet numbers

I've taken your suggestion but rephrased to avoid a run-on sentence.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2340#discussion_r248898815