Re: [quicwg/base-drafts] Allow not creating QPACK codec streams (#2529)

afrind <notifications@github.com> Thu, 21 March 2019 19:08 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F27081311D5 for <quic-issues@ietfa.amsl.com>; Thu, 21 Mar 2019 12:08:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3
X-Spam-Level:
X-Spam-Status: No, score=-3 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id knAFBk1oFQWX for <quic-issues@ietfa.amsl.com>; Thu, 21 Mar 2019 12:08:48 -0700 (PDT)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B7AE413110F for <quic-issues@ietf.org>; Thu, 21 Mar 2019 12:08:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=pApG0L5tLtj/HLKuQhJY2TMlSt8=; b=iwqpWs3G6D5dSJ6/ b2F7KULyhpMy5WNhCmRLx0KB0Y+spk45Wwm3XbZgnrFQNYKjqTTSeQWZHO906zgG yW/PnZqVbyhkycniIpGmSE+j2NQbXHCdzfuXwGXg724fTxMb3mwq4eMm3/HhvJbc 6pBZgZuVEwqxa7d5clo3qNPFM3o=
Received: by filter1137p1las1.sendgrid.net with SMTP id filter1137p1las1-9076-5C93E13F-1F 2019-03-21 19:08:47.397629762 +0000 UTC m=+17034.364374731
Received: from github-lowworker-e711880.cp1-iad.github.net (unknown [192.30.252.45]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id bp9SFWwGQNqkDjESWYrRbQ for <quic-issues@ietf.org>; Thu, 21 Mar 2019 19:08:47.290 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e711880.cp1-iad.github.net (Postfix) with ESMTP id 44A0C440800 for <quic-issues@ietf.org>; Thu, 21 Mar 2019 12:08:47 -0700 (PDT)
Date: Thu, 21 Mar 2019 19:08:47 +0000
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6acb232c2e8d92423db3d717eb11d8cda82f350c92cf0000000118aba33f92a169ce1931c3e6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2529/review/217439374@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2529@github.com>
References: <quicwg/base-drafts/pull/2529@github.com>
Subject: Re: [quicwg/base-drafts] Allow not creating QPACK codec streams (#2529)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c93e13f43498_5de93f833acd45b826144e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2BhnHS97cn7OW2eb+vgxsX8m2HSZa7Qlg0li ApCrr3m8ioNDnW9azDpnoItOgBOT8JzaLv2aH/74g7YQkFRxQWcJQe2rZ9ekslwT4GiAdwdDjT3xCX epHP8OzlrTqdAH1IzKizUHa/AOQK6V5Wkgc5gepj6ATaF66W/56wDsG8UA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/bZpFOE86IHIuHsyed10MzV-vm2s>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Mar 2019 19:08:52 -0000

afrind commented on this pull request.



>  HTTP_WRONG_STREAM_COUNT. These streams MUST NOT be closed. Closure of either
 unidirectional stream type MUST be treated as a connection error of type
 HTTP_CLOSED_CRITICAL_STREAM.
 
+An endpoint MAY avoid creating its own encoder stream if the maximum size of
+the dynamic table permitted by the peer is zero.
+
+An endpoint MAY avoid creating its own decoder stream if the maximum size of
+its own dynamic table is zero.
+
+An endpoint MUST allow its peer to create both encoder and decoder streams

This sounds like a case of "don't do that".  The sender gets to choose to how to use the uni stream credit it receives, and I don't think receivers should overthink this.  A receiver should choose the value based on how many concurrent uni streams they can handle, since there's no way to guaranteer the sender will use them for any particular type.  If the sender wants to use the dynamic table at any point in the connection, maybe we should recommend they open the stream as soon as possible.  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2529#discussion_r267915538