IETF Logo Mail Archive

Re: [quicwg/base-drafts] Define stream limits as counts (#1906)

MikkelFJ <notifications@github.com> Fri, 26 October 2018 00:01 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9C5C8130E1A for <quic-issues@ietfa.amsl.com>; Thu, 25 Oct 2018 17:01:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oJ2g9HC6nMQ0 for <quic-issues@ietfa.amsl.com>; Thu, 25 Oct 2018 17:01:12 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 178DD130E19 for <quic-issues@ietf.org>; Thu, 25 Oct 2018 17:01:12 -0700 (PDT)
Date: Thu, 25 Oct 2018 17:01:11 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540512071; bh=qS3RhbQGYgGY+r5LdHhkZDjKZwCtK0V4heIB8mfYtzY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=jdTs82Ku/mwoapGG01wdnTG6mR5uacjk3vqmo0QIB8di/Le1mvzFE27FSrkcYHt3B LUG85NWDxdMUciJ5xNG/iy6sFhdp8lK/iucsuAJWdv3usJydJvO3GfZBfxOngBkg5n Z7BZm5e15ikB2X779XcjiFKh4OhhGyrvdN6L9lvE=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf00e58be4cc54bb2d82718170b87b8af91b1ef2a92cf0000000117ea1b4792a169ce1646c612@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1906/review/168631803@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1906@github.com>
References: <quicwg/base-drafts/pull/1906@github.com>
Subject: Re: [quicwg/base-drafts] Define stream limits as counts (#1906)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd2594766993_23613fe9808d45c41409477"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/bdTs2dbN5OsaLWPikrr_d3oDcpo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Oct 2018 00:01:14 -0000

mikkelfj commented on this pull request.



> @@ -4247,11 +4247,11 @@ Loss or reordering can mean that a MAX_STREAMS frame can be received which
 states a lower stream limit than the client has previously received.
 MAX_STREAMS frames which do not increase the stream limit MUST be ignored.
 
-A peer MUST NOT initiate a stream with a higher stream ID than the largest limit
-it has received permits.  For instance, a server that receives a unidirectional
-stream limit of 3 is permitted to open stream 3, 7, and 11, but not stream 15.
-An endpoint MUST terminate a connection with a STREAM_LIMIT_ERROR error if a
-peer opens more streams than was permitted.
+A peer MUST NOT open more streams than the limit it received permits.  For

Is that a sentence?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1906#pullrequestreview-168631803

v2.46.0 | Report a Bug | By Email | System Status