Re: [quicwg/base-drafts] Proposal for adding ECN support to QUIC. (#1372)

Magnus Westerlund <notifications@github.com> Tue, 12 June 2018 09:33 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 61FD113112B for <quic-issues@ietfa.amsl.com>; Tue, 12 Jun 2018 02:33:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.009
X-Spam-Level:
X-Spam-Status: No, score=-3.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aebkI_h2ITDH for <quic-issues@ietfa.amsl.com>; Tue, 12 Jun 2018 02:33:53 -0700 (PDT)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7EE1D130F6D for <quic-issues@ietf.org>; Tue, 12 Jun 2018 02:33:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=gWTyHZph7RgvsOyJwfpTSP1ljXY=; b=vcvieqXuAHzhTnlg NbCVKlNz+fJ64k/eQMsK5Hsm9pS18r5vPTSRP+TL9ma33uGM92/TIL/hbVntQKgC Xty+8EdI8zqm11ixG01cFz54Ut2ad92ypqGdfBY05lTaZH6ygzFb+m3MAjRkGxMl hp3q8B8PK61rOrnDQs61wJGV/+w=
Received: by filter0823p1las1.sendgrid.net with SMTP id filter0823p1las1-22504-5B1F9380-4 2018-06-12 09:33:52.226351567 +0000 UTC
Received: from github-lowworker11-cp1-prd.iad.github.net (unknown [192.30.252.35]) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id -5H4_jA_SAO1rYfMU53ZmQ for <quic-issues@ietf.org>; Tue, 12 Jun 2018 09:33:52.163 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker11-cp1-prd.iad.github.net (Postfix) with ESMTP id 2691BE1080 for <quic-issues@ietf.org>; Tue, 12 Jun 2018 02:33:52 -0700 (PDT)
Date: Tue, 12 Jun 2018 09:33:52 +0000
From: Magnus Westerlund <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4a17a424611f96525bd5e0845700353d885bb9d892cf000000011737558092a169ce13656182@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1372/review/127886927@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1372@github.com>
References: <quicwg/base-drafts/pull/1372@github.com>
Subject: Re: [quicwg/base-drafts] Proposal for adding ECN support to QUIC. (#1372)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b1f938025156_3deb3fd7f07cef7c5585c3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gloinul
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2HoRSTcTZq9YgF2GF3llJlUQ1dJCHuM7n8Nf vZRtH8Dr0Nocd3mpnOCpsncw2QetO8U0gEV+IQAHuSvGlWGofirVSP6QEOcwolID1X0DvEZIA7kKvE IS/ziFxJ9T1YJtW5ZSC1jAeXwuALt76sXKbUC5/u2zY530s9MaWTlLbq9kweQAmeTy7XQGSG5mwirp M=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/bj-I3r0RUSMpktk3GL-ayll_C8Y>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jun 2018 09:33:57 -0000

gloinul commented on this pull request.



> +connection is migrated then the ECN capability check is rerun as specified in
+{{ecn-connection-migration}}.
+
+It is expected that QUIC discards duplicate packets early, however if that is
+not the case **\[ED note, have not seen any clear statement in the drafts]**,
+then it should be verified that the number of ECT marked packets are equal to or
+larger that the amount of ECT marked packets that have been transmitted.
+
+### Continous Verification of ECN {#ecn-continous-verification}
+
+If the ECN capabiity check was successful and the endpoint continus to send ECT
+marked packets then continous verification is applied. This is to detect any
+cases when ECN field is bleached, that is, zeroed out by a network node, likely
+as the result of a routing changes since the ECN capability check.
+
+For each ACK_ECN frame that is received, the total number of ACKed packets are

Yes, except that larger needs to be less in this case. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1372#discussion_r194673645