Re: [quicwg/base-drafts] http-core and Friends (#3513)

Martin Thomson <notifications@github.com> Wed, 11 March 2020 22:44 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B5F353A08DE for <quic-issues@ietfa.amsl.com>; Wed, 11 Mar 2020 15:44:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.099
X-Spam-Level:
X-Spam-Status: No, score=-3.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4UPlxesnQIR1 for <quic-issues@ietfa.amsl.com>; Wed, 11 Mar 2020 15:44:43 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 876B43A0902 for <quic-issues@ietf.org>; Wed, 11 Mar 2020 15:44:41 -0700 (PDT)
Received: from github-lowworker-275fa97.va3-iad.github.net (github-lowworker-275fa97.va3-iad.github.net [10.48.17.64]) by smtp.github.com (Postfix) with ESMTP id 86EB1E0DBB for <quic-issues@ietf.org>; Wed, 11 Mar 2020 15:44:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1583966680; bh=mrK2Ja+8VQoMGe4HgjQQzsKLzGU9gAVSl/9RZFjubb4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=JhHS4mG0SFHWhkY8go5w6kvfoBmAoWGvfkq4ihZBxaD+ycjzHyF/a5a7tkDBUkDsM MjTR4I2DQ0F35W8mqrCJAZk5b2WqyU4TXmcOOkh/hD41d2OHj4nc6PANDxhC7NHFyA KkaUMaUT6Vss/HsCCHkli3D/3qklp2D4DWP/k+EA=
Date: Wed, 11 Mar 2020 15:44:40 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK36U3I2KYN7M46ALEF4OVFNREVBNHHCFCTWBI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3513/review/373173645@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3513@github.com>
References: <quicwg/base-drafts/pull/3513@github.com>
Subject: Re: [quicwg/base-drafts] http-core and Friends (#3513)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e6969d877d91_1e173ff55d2cd96c2956ee"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/bl16UHr5d6fgXpJPK2ukFgh4Ux0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Mar 2020 22:44:45 -0000

martinthomson approved this pull request.

FIELDS!

> @@ -86,25 +86,28 @@ code and issues list for this draft can be found at
 
 # Introduction
 
-HTTP semantics are used for a broad range of services on the Internet. These
-semantics have commonly been used with two different TCP mappings, HTTP/1.1 and
-HTTP/2.  HTTP/3 supports the same semantics over a new transport protocol, QUIC.
+HTTP semantics {{!Semantics=I-D.ietf-httpbis-semantics}} are used for a broad

```suggestion
HTTP semantics {{!SEMANTICS=I-D.ietf-httpbis-semantics}} are used for a broad
```
All caps is, I think that is conventional.

> @@ -820,11 +820,12 @@ CANCEL_PUSH frame, the client can abort reading the stream with an error code of
 H3_REQUEST_CANCELLED. This asks the server not to transfer additional data and
 indicates that it will be discarded upon receipt.
 
-Pushed responses that are cacheable (see Section 3 of {{!RFC7234}}) can be
-stored by the client, if it implements an HTTP cache.  Pushed responses are
-considered successfully validated on the origin server (e.g., if the "no-cache"
-cache response directive is present (Section 5.2.2 of {{!RFC7234}})) at the time
-the pushed response is received.
+Pushed responses that are cacheable (see Section 3 of
+{{!Caching=I-D.ietf-httpbis-cache}}) can be stored by the client, if it

```suggestion
{{!CACHING=I-D.ietf-httpbis-cache}}) can be stored by the client, if it
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3513#pullrequestreview-373173645