Date: Fri, 21 Sep 2018 16:36:18 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab5c4bc815ebe9d9b6494bb4f21941409ea5428df392cf0000000117bd427292a169ce1599c7ba@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1782/review/157886782@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1782@github.com>
References: <quicwg/base-drafts/pull/1782@github.com>
Subject: Re: [quicwg/base-drafts] No longer calculate max_ack_delay in
 recovery (#1782)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5ba580723543c_19b3ff9cb8d45b4128969";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/boT84UrfNQaKcEvLAPXjzfyekBI>


----==_mimepart_5ba580723543c_19b3ff9cb8d45b4128969
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

martinthomson approved this pull request.

I assume that I just haven't seen the transport piece of this yet.

> @@ -598,9 +598,10 @@ min_rtt:
 : The minimum RTT seen in the connection, ignoring ack delay.
 
 max_ack_delay:
-: The maximum ack delay in an incoming ACK frame for this connection.
-  Excludes ack delays for non-retransmittable packets and those
-  that create an RTT sample less than min_rtt.
+: The value from the `max_ack_delay` transport parameter, which
+  indicates the maximum amount of time in milliseconds the receiver

the maximum amount of time by which the receiver intends to delay acknowledgments, in milliseconds

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1782#pullrequestreview-157886782
----==_mimepart_5ba580723543c_19b3ff9cb8d45b4128969
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@martinthomson</b> approved this pull request.</p>

<p>I assume that I just haven't seen the transport piece of this yet.</p><hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/1782#discussion_r219650515">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt; @@ -598,9 +598,10 @@ min_rtt:
 : The minimum RTT seen in the connection, ignoring ack delay.
 
 max_ack_delay:
-: The maximum ack delay in an incoming ACK frame for this connection.
-  Excludes ack delays for non-retransmittable packets and those
-  that create an RTT sample less than min_rtt.
+: The value from the `max_ack_delay` transport parameter, which
+  indicates the maximum amount of time in milliseconds the receiver
</pre>
<p>the maximum amount of time by which the receiver intends to delay acknowledgments, in milliseconds</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/1782#pullrequestreview-157886782">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq40r60zRD-yBaZLDYIc0QRWamf74ks5udXfygaJpZM4WzML_">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq0UtwAGHz380_A6JRhr_2KTANOQQks5udXfygaJpZM4WzML_.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@martinthomson approved #1782"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/1782#pullrequestreview-157886782"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/1782#pullrequestreview-157886782",
"url": "https://github.com/quicwg/base-drafts/pull/1782#pullrequestreview-157886782",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@martinthomson approved 1782",
"sections": [
{
"text": "I assume that I just haven't seen the transport piece of this yet.",
"activityTitle": "**Martin Thomson**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@martinthomson",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/1782#pullrequestreview-157886782"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 382518015\n}"
}
],
"themeColor": "26292E"
}
]</script>
----==_mimepart_5ba580723543c_19b3ff9cb8d45b4128969--