Re: [quicwg/base-drafts] Push stream data and PUSH_PROMISE reordering clarification (#2527)

Robin Marx <notifications@github.com> Tue, 19 March 2019 09:48 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7E80D131219 for <quic-issues@ietfa.amsl.com>; Tue, 19 Mar 2019 02:48:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.001
X-Spam-Level:
X-Spam-Status: No, score=-8.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fp2Ky8NdLIrd for <quic-issues@ietfa.amsl.com>; Tue, 19 Mar 2019 02:48:04 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D0415131200 for <quic-issues@ietf.org>; Tue, 19 Mar 2019 02:48:03 -0700 (PDT)
Date: Tue, 19 Mar 2019 02:48:03 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1552988883; bh=nkAxARJlRuqNNzpKNa3HStqMK2QDK+xh6iRjOMcdcSg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=rhhmYJdhKnuzh4j9wgxiVbFRkAHmh2vnZvS7nZtjLGUUwsJcIBZyHCbiSnVUvXTuL 4ao0s/DKbvcvn5RPFmvgvOgt7dyQ+G7h52dpZ6eHwtdrw+JllhJI2roQ25H1QuzQqo WvnY57sxApDzRGv/zYzQwhDnrnoaa/iqhSoCo3nI=
From: Robin Marx <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ababab94b8a96d678737cda84db11a90747321db8992cf0000000118a87cd392a169ce19290f08@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2527/review/216049073@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2527@github.com>
References: <quicwg/base-drafts/pull/2527@github.com>
Subject: Re: [quicwg/base-drafts] Push stream data and PUSH_PROMISE reordering clarification (#2527)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c90bad36a1c_603c3fcad70d45bc718e1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: rmarx
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/brQy3Z1YOzaEGeLO91XONdUq3XA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Mar 2019 09:48:06 -0000

rmarx commented on this pull request.



> @@ -1207,7 +1207,14 @@ the requests if the requested resource is already being pushed.
 When a server later fulfills a promise, the server push response is conveyed on
 a push stream (see {{push-streams}}). The push stream identifies the Push ID of
 the promise that it fulfills, then contains a response to the promised request
-using the same format described for responses in {{request-response}}.
+using the same format described for responses in {{request-response}}. Due to
+reordering, data on a push stream can arrive before the corresponding
+PUSH_PROMISE, in which case both the associated client request and the pushed
+request headers are unknown. Clients which receive a new push stream with an

That was based on identical text for DUPLICATE_PUSH a few lines up. I've now also changed that to keep consistency. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2527#discussion_r266802290