Re: [quicwg/base-drafts] Unidirectional Streams (#643)

Mike Bishop <notifications@github.com> Tue, 27 June 2017 18:25 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 980F712EAED for <quic-issues@ietfa.amsl.com>; Tue, 27 Jun 2017 11:25:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.019
X-Spam-Level:
X-Spam-Status: No, score=-2.019 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7qhI3qCmAaIZ for <quic-issues@ietfa.amsl.com>; Tue, 27 Jun 2017 11:25:21 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D7367129C07 for <quic-issues@ietf.org>; Tue, 27 Jun 2017 11:25:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=r90QA6TZQmZWzwu7RFgBHtLFjxk=; b=lKiIsnvCksG91Nsm rW2A/gxAPeJCXexNl/jt8zW4KhhBSt61vWgkoKKjzHGzlB83QXzGCvpMe1IE62hd df3VWWXsPVXwlRhKTPuDYqGy7HMBT6Y+3tDO37baWi6VwIA/fcUIbpq7Vgq+fVPM A3EEcOxeom1XWViMfhxRbArRY/A=
Received: by filter0441p1mdw1.sendgrid.net with SMTP id filter0441p1mdw1-15828-5952A30B-1F 2017-06-27 18:25:15.327301567 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id 43y90fVbRtSfuPl3pWdpWA for <quic-issues@ietf.org>; Tue, 27 Jun 2017 18:25:15.303 +0000 (UTC)
Date: Tue, 27 Jun 2017 11:25:15 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7e7ad6ba02e08f563f16d5924a735a1f76358ee592cf00000001156a650b92a169ce0e21ecbf@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/643/review/46638462@github.com>
In-Reply-To: <quicwg/base-drafts/pull/643@github.com>
References: <quicwg/base-drafts/pull/643@github.com>
Subject: Re: [quicwg/base-drafts] Unidirectional Streams (#643)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5952a30b358a2_4823fbf85aebc38115541"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2RWEP2rAYH3S50XSklMbNtyp6CVozqpiG/AS be13DO1Opp2SCUYcjvckYKgw4hyKKcpGgXMdZXzqoe5JQPzm2fXJ/9oAdCQJumC46GkdnI6a9kdqEa O84ljRyqR2PqcNFXeoSpGYiLiCQZ1nOyQS916QWB1uFW/BQkQQx/NqIDdfSn195uh5LSMWS5PW15Dx A=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/btoz73mnLzw0dIVYP7rA3zCBNwc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Jun 2017 18:25:22 -0000

MikeBishop commented on this pull request.



> +
+An endpoint MUST terminate the connection with an HTTP_INVALID_STREAM_HEADER
+error if it receives a stream header that uses an unknown or unsupported type.
+
+
+### Stream 1: Connection Control Stream {#stream-control}
+
+Stream 1 is opened by both client and server and is used for the SETTINGS frame
+immediately after the connection opens.  After the SETTINGS frame has been sent,
+this stream is used for PRIORITY and CANCEL_REQUEST frames.
+
+There is no stream header for a connection control stream; the stream is
+identified by its stream number.  The connection control stream contains a
+sequence of frames, starting with the SETTINGS frame.
+
+If an endpoint receives a stream type of 0xff on any stream other than stream 1,

I think two versions collided here.  Stream type 0xff is undefined, so it's also invalid on Stream 1.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/643#pullrequestreview-46638462