Re: [quicwg/base-drafts] avoid setting the loss timer when amplification limited (#3596)
Jana Iyengar <notifications@github.com> Tue, 28 April 2020 22:37 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0548E3A0529 for <quic-issues@ietfa.amsl.com>; Tue, 28 Apr 2020 15:37:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.008
X-Spam-Level:
X-Spam-Status: No, score=-2.008 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s20pXs1Hx0hA for <quic-issues@ietfa.amsl.com>; Tue, 28 Apr 2020 15:37:47 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BCB983A0524 for <quic-issues@ietf.org>; Tue, 28 Apr 2020 15:37:47 -0700 (PDT)
Received: from github-lowworker-1dbcc59.ash1-iad.github.net (github-lowworker-1dbcc59.ash1-iad.github.net [10.56.105.54]) by smtp.github.com (Postfix) with ESMTP id 82830A0D79 for <quic-issues@ietf.org>; Tue, 28 Apr 2020 15:37:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1588113466; bh=9U7pn5XFpW39+i3e7ykM6V9qX7NR8R5Xw6kuqCBAYkU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=iY+qyCsGm0jVAglQIIeo7jdY/l2mvbNyvN/CYnv0poLgs/GZrNVa3z2Iyh/I5oOpo 6hTlWVagHnD9UgJWwY0mySxQ9dKbk07YSW4Oq9+kU+RcoArceTtXuRJeq14PJ7CQ4q 3YYnR1KkeZl5eV1a9zTGns+CGkeyGR7pkAbEV9V4=
Date: Tue, 28 Apr 2020 15:37:46 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5EQSPT7NOYQKXWHDV4WSITVEVBNHHCIE6WVA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3596/c620891691@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3596@github.com>
References: <quicwg/base-drafts/pull/3596@github.com>
Subject: Re: [quicwg/base-drafts] avoid setting the loss timer when amplification limited (#3596)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ea8b03a72894_523d3f86a7acd95c8232d8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/bzxVCoWMud6ZoGCEmuf93fQmINA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Apr 2020 22:37:49 -0000
Let's not do this. There's a potential deadlock here: if the server does not mark the packet as lost, it will not retransmit later when a data packet is received from the client that opens up the server to send. Basically, the server only marks packets as lost on receiving an ACK, and if you make this change, the server could end up never marking a handshake packet as lost. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3596#issuecomment-620891691
- [quicwg/base-drafts] avoid setting the loss timer… Marten Seemann
- Re: [quicwg/base-drafts] avoid setting the loss t… Marten Seemann
- Re: [quicwg/base-drafts] avoid setting the loss t… ianswett
- Re: [quicwg/base-drafts] avoid setting the loss t… Marten Seemann
- Re: [quicwg/base-drafts] avoid setting the loss t… Jana Iyengar
- Re: [quicwg/base-drafts] avoid setting the loss t… Jana Iyengar
- Re: [quicwg/base-drafts] avoid setting the loss t… Jana Iyengar