Date: Wed, 12 Dec 2018 15:07:50 -0800
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4abf9cc80902b544672b477ee496c8f860a5e36650592cf00000001182956c692a169ce173f3512@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2119/review/184438014@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2119@github.com>
References: <quicwg/base-drafts/pull/2119@github.com>
Subject: Re: [quicwg/base-drafts] Add FACK reference (#2119)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5c1194c69c1b8_26163f96deed45b81823d9";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/c1QoPmWIej28LhCkYPp2cK0va84>


----==_mimepart_5c1194c69c1b8_26163f96deed45b81823d9
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

janaiyengar commented on this pull request.



> @@ -325,7 +334,8 @@ smaller initial reordering thresholds to minimize recovery latency.
 ### Packet Threshold
 
 The RECOMMENDED initial value for the packet reordering threshold
-(kPacketThreshold) is 3, based on TCP loss detection {{?RFC5681}} {{?RFC6675}}.
+(kPacketThreshold) is 3, based on best practices for TCP loss detection
+{{?RFC5681}} {{?RFC6675}} {{FACK}}.

yup, moved

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2119#discussion_r241218866
----==_mimepart_5c1194c69c1b8_26163f96deed45b81823d9
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@janaiyengar</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2119#discussion_r241218866">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt; @@ -325,7 +334,8 @@ smaller initial reordering thresholds to minimize recovery latency.
 ### Packet Threshold
 
 The RECOMMENDED initial value for the packet reordering threshold
-(kPacketThreshold) is 3, based on TCP loss detection {{?RFC5681}} {{?RFC6675}}.
+(kPacketThreshold) is 3, based on best practices for TCP loss detection
+{{?RFC5681}} {{?RFC6675}} {{FACK}}.
</pre>
<p>yup, moved</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2119#discussion_r241218866">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq56XUwuX_2ML4eRtHlPQ-LlLBnf0ks5u4YxGgaJpZM4ZOhef">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkqwF3jxn3hFerq56ft3AHY6FR37ygks5u4YxGgaJpZM4ZOhef.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@janaiyengar commented on #2119"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/2119#discussion_r241218866"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2119#discussion_r241218866",
"url": "https://github.com/quicwg/base-drafts/pull/2119#discussion_r241218866",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5c1194c69c1b8_26163f96deed45b81823d9--