Re: [quicwg/base-drafts] Allow not creating QPACK codec streams (#2529)

Lucas Pardue <notifications@github.com> Tue, 19 March 2019 15:05 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 65EE51313A7 for <quic-issues@ietfa.amsl.com>; Tue, 19 Mar 2019 08:05:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3
X-Spam-Level:
X-Spam-Status: No, score=-3 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9KcFiuvJUsDA for <quic-issues@ietfa.amsl.com>; Tue, 19 Mar 2019 08:05:05 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 465741313E9 for <quic-issues@ietf.org>; Tue, 19 Mar 2019 08:05:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=mc33YoMhJb6K3VwtsTQml83ij84=; b=FO1we656Y5fHQ1zm PNe1sPKvBeO2S2Ac8rjNz6YPwwu7A0KHaEnrRhtQaqxzxPyqMFowHHjPhFz8QANs 9eDuqjws8mU2t7f7CTYxO8dhPWvlVhmurf1vsEHYnjnXeJPGo9Oc3XakLpMxEVMf E6lyUNtfO5C+xjS0o+K0Tmi/+bs=
Received: by filter0064p1iad2.sendgrid.net with SMTP id filter0064p1iad2-26289-5C910520-1A 2019-03-19 15:05:04.266786974 +0000 UTC m=+334763.568756689
Received: from github-lowworker-1c220e1.cp1-iad.github.net (unknown [192.30.252.44]) by ismtpd0021p1iad2.sendgrid.net (SG) with ESMTP id XZtTAMDhR326TCZ-dNzrKQ for <quic-issues@ietf.org>; Tue, 19 Mar 2019 15:05:04.252 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-1c220e1.cp1-iad.github.net (Postfix) with ESMTP id 43269160BE9 for <quic-issues@ietf.org>; Tue, 19 Mar 2019 08:05:04 -0700 (PDT)
Date: Tue, 19 Mar 2019 15:05:04 +0000
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab18a2b111055f9265b625f9e8ff6328bf4c1243cb92cf0000000118a8c72092a169ce1931c3e6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2529/review/216217810@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2529@github.com>
References: <quicwg/base-drafts/pull/2529@github.com>
Subject: Re: [quicwg/base-drafts] Allow not creating QPACK codec streams (#2529)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c91052040de5_2f813f7f8bcd45c0377354"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak12pMuktelUfi1Wg4NEfqWlS1CM+h7l+bTMUG awoqwUxQH0GeTvwKs5u2L4ArPKYjJzIyxEoJ4sVGWRn/aKEf/gEnybWqmwvbh/xbhenGJ1SdACGhC4 +nLH29o7qCZ5PgsFndKEc1S5pu7Ra25u57xNy/bb6wOhoRWHOKJEmnCVYSwadHTC/WO9IHPccPtLk6 Y=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/c5VT0BtRwV1ONivLIauB90f051g>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Mar 2019 15:05:15 -0000

LPardue commented on this pull request.



>  HTTP_WRONG_STREAM_COUNT. These streams MUST NOT be closed. Closure of either
 unidirectional stream type MUST be treated as a connection error of type
 HTTP_CLOSED_CRITICAL_STREAM.
 
+An endpoint MAY avoid creating its own encoder stream if the maximum size of

I think this is telling that the current definition of signalling around QPACK is all a bit wrong. The receiver tells the sender if it is willing to support dynamic compression but there is no explicit signal it will happen until a stream is opened, are we happy with that?

For @ianswett's issue, an additional clause to this sentence could help e.g. 

"An endpoint MAY avoid creating its own encoder stream if the maximum size of the dynamic table permitted by the peer is zero, or if the endpoint doesn't want to use the dynamic table."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2529#discussion_r266936540