IETF Logo Mail Archive

Re: [quicwg/base-drafts] endpoints are allowed to retransmit entire payload of a lost packet (#2312)

Martin Thomson <notifications@github.com> Tue, 08 January 2019 22:23 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 870401311A8 for <quic-issues@ietfa.amsl.com>; Tue, 8 Jan 2019 14:23:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.661
X-Spam-Level:
X-Spam-Status: No, score=-6.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lH7bIkzhokQF for <quic-issues@ietfa.amsl.com>; Tue, 8 Jan 2019 14:23:39 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5D9541311A4 for <quic-issues@ietf.org>; Tue, 8 Jan 2019 14:23:39 -0800 (PST)
Date: Tue, 08 Jan 2019 14:23:38 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546986218; bh=8s6SNc/kssjPRLGsBgDU8Kn9744ZeVn1q6qpPo2MkjM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=KF+se9E4N7VHHVp4XGAYwzvA/cVvf42MVnZJx0y21i8fQPw3a0QTuxlAlurWPvSgu 4n2TSbt7tpzaQ87V855OISzlhjd5g+yiTbAXYH/fARCE/K5oNQ3gogJi82hnFxfnIb Z4m4uM/x/+cqLUVOBQOehZJ2EoO92HLrm7ZquE64=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab00fa64d79584b689ca62e10ce49678d4a6b5c8a992cf00000001184ce4ea92a169ce17a42515@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2312/review/190471406@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2312@github.com>
References: <quicwg/base-drafts/pull/2312@github.com>
Subject: Re: [quicwg/base-drafts] endpoints are allowed to retransmit entire payload of a lost packet (#2312)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c3522ea74a3b_29733fd70bad45b81173fd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/cMtUXVWi_9uYQBPjwuIdf5z-bog>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jan 2019 22:23:41 -0000

martinthomson approved this pull request.



> @@ -2985,6 +2985,12 @@ Endpoints SHOULD prioritize retransmission of data over sending new data, unless
 priorities specified by the application indicate otherwise (see
 {{stream-prioritization}}).
 
+Even though a sender is encouraged to assemble frames containing up-to-date
+information every time it sends a packet, it is not forbidden to retransmit
+frames of lost packets as they are.  A receiver MUST accept packets containing

```suggestion
copies of frames from lost packets.  A receiver MUST accept packets containing
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2312#pullrequestreview-190471406

v2.23.0 | Report a Bug | By Email