IETF Logo Mail Archive

Re: [quicwg/base-drafts] Allow longer CIDs (#2749)

David Schinazi <notifications@github.com> Mon, 03 June 2019 14:19 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E45DF120277 for <quic-issues@ietfa.amsl.com>; Mon, 3 Jun 2019 07:19:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.009
X-Spam-Level:
X-Spam-Status: No, score=-3.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nUNeeMiYLbpo for <quic-issues@ietfa.amsl.com>; Mon, 3 Jun 2019 07:19:43 -0700 (PDT)
Received: from o10.sgmail.github.com (o10.sgmail.github.com [167.89.101.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 43B591202B4 for <quic-issues@ietf.org>; Mon, 3 Jun 2019 07:19:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=jaBU6plFPaT25BCLfYxdi6HwV/I=; b=ISwkPY9m9+VGACXC udq0e2VAM76kswAOw0IjDxV2I0dqzWmSqgPXKIt9rcVg96FpWiMCnhpTSWG2QAMK LaCjOIosdz6FDp0ShJQdjLIIvYPzXOn1CI5rHbFdzDvYxeNfsqdMx//6qhUAC0pt IeQ9x2Q7I1Hf72P4Gk945XxaRDo=
Received: by filter1361p1mdw1.sendgrid.net with SMTP id filter1361p1mdw1-1972-5CF52C7C-1 2019-06-03 14:19:40.025146471 +0000 UTC m=+934809.117244943
Received: from github-lowworker-1c220e1.cp1-iad.github.net (unknown [140.82.115.1]) by ismtpd0023p1iad2.sendgrid.net (SG) with ESMTP id l0q-sORTT5OdCYHzDmX9Dg for <quic-issues@ietf.org>; Mon, 03 Jun 2019 14:19:39.926 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-1c220e1.cp1-iad.github.net (Postfix) with ESMTP id E0F6A160855 for <quic-issues@ietf.org>; Mon, 3 Jun 2019 07:19:39 -0700 (PDT)
Date: Mon, 03 Jun 2019 14:19:40 +0000
From: David Schinazi <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK74TWVHVE42HLYOYDN3AJPPXEVBNHHBVJ2RLQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2749/c498276578@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2749@github.com>
References: <quicwg/base-drafts/pull/2749@github.com>
Subject: Re: [quicwg/base-drafts] Allow longer CIDs (#2749)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cf52c7bddf80_4c7d3fb6902cd96440018a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: DavidSchinazi
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1fIncaOPWHbgmUeIH3yVG48qDJpRMxEh8TIY cZzSuR5eG8o/F0rmvdy4+7w2d4whFHMEVkAGYMbuS3d2smaottzBTwqDkNXBFTLDahOzEdSoDMq28L 26LG5FD/os3fL4afS7EVDjxAJjdk0zxXWgSJpCvwtTkXsDrB13566hKIDuRVPM4VxCQe5dDz/Ziozw k=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/cQ7OLVjRndCSEz3sEhk15eaVQqg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Jun 2019 14:19:51 -0000

This CL also needs to change the encoding of the Original Destination Connection ID Length (ODCIL) in Retry packets. It is currently encoded as the four least significant bits of the first byte and that won't fit anymore. I'd suggest moving ODCIL to be a full byte between the Source Connection ID and the Original Destination Connection ID. I would then mark the four least significant bits of the first byte of Retry packets as unused similar to Version Negotiation packets.

```
 0                   1                   2                   3
 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
+-+-+-+-+-+-+-+-+
|1|1| 3 | Unused|
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|                         Version (32)                          |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|    DCIL (8)   |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|               Destination Connection ID (0..384)            ...
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|    SCIL (8)   |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|                 Source Connection ID (0..384)               ...
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|   ODCIL (8)   |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|          Original Destination Connection ID (0..384)        ...
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|                        Retry Token (*)                      ...
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2749#issuecomment-498276578

v2.23.0 | Report a Bug | By Email