Re: [quicwg/base-drafts] Server Ignore VN Packets (#2088)
Martin Thomson <notifications@github.com> Sun, 02 December 2018 23:14 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6B3D5130DCC for <quic-issues@ietfa.amsl.com>; Sun, 2 Dec 2018 15:14:12 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NEcmY5RtHrb9 for <quic-issues@ietfa.amsl.com>; Sun, 2 Dec 2018 15:14:10 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7F423130DCB for <quic-issues@ietf.org>; Sun, 2 Dec 2018 15:14:10 -0800 (PST)
Date: Sun, 02 Dec 2018 15:14:09 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543792449; bh=sbatsq11FYb4ZiQQNGEbwCnwDpGk5oJKVhMSgk0RpMM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dpN5Xw0BL4emzgBjQaacyvOkEy7BbZ61G3Hk6lTCXbfjMqsErnYrSxTl2lKoXH1CW k0JFeiltSOQ2R0Fm7PG05fHjmdmcTTPGwvGzh8cy6by3+1tptdR7KyvKMOpgFXsGRn 49PvgtDj0LHIGveUHbcw0F3VlMQrO3GcHaW2Q1OA=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab1441d059841ab2ffdd17a0022f430c7e96071f0f92cf00000001181c294192a169ce170940d9@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2088/review/180583385@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2088@github.com>
References: <quicwg/base-drafts/pull/2088@github.com>
Subject: Re: [quicwg/base-drafts] Server Ignore VN Packets (#2088)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c04674198bb2_63fc3fb5f52d45c01911fa"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/cR7kPk8Ycd6AW_Z5V41qV_pBlPs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Dec 2018 23:14:13 -0000
martinthomson approved this pull request.
With the adjustment, lgtm.
> @@ -1108,7 +1108,9 @@ is a mutually supported version.
If the version selected by the client is not acceptable to the server, the
server responds with a Version Negotiation packet (see {{packet-version}}).
-This includes a list of versions that the server will accept.
+This includes a list of versions that the server will accept. A server MUST NOT
+send a Version Negotiation packet in response to receiving a Version Negotiation
+packet because it could trigger and endless back and forth between two servers.
```suggestion
packet.
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2088#pullrequestreview-180583385
- [quicwg/base-drafts] Server Ignore VN Packets (#2… Nick Banks
- Re: [quicwg/base-drafts] Server Ignore VN Packets… ianswett
- Re: [quicwg/base-drafts] Server Ignore VN Packets… MikkelFJ
- Re: [quicwg/base-drafts] Server Ignore VN Packets… Martin Thomson
- Re: [quicwg/base-drafts] Server Ignore VN Packets… Nick Banks
- Re: [quicwg/base-drafts] Server Ignore VN Packets… Martin Thomson
- Re: [quicwg/base-drafts] Server Ignore VN Packets… Martin Thomson
- Re: [quicwg/base-drafts] Server Ignore VN Packets… Mike Bishop
- Re: [quicwg/base-drafts] Server Ignore VN Packets… ianswett