Date: Tue, 23 Oct 2018 16:44:00 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab1cc598848a79d4a4917c86da43d3ee341d34b71292cf0000000117e7744092a169ce16295b25@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1890/review/167682003@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1890@github.com>
References: <quicwg/base-drafts/pull/1890@github.com>
Subject: Re: [quicwg/base-drafts] Specify the packets that carry closing
 frames (#1890)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5bcfb2401d425_18173fd0608d45bc8476";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ckdjZogjFjQawLqKL30QNlYozG0>


----==_mimepart_5bcfb2401d425_18173fd0608d45bc8476
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

martinthomson commented on this pull request.



> @@ -2251,6 +2242,13 @@ the application requests that the connection be closed.  The application
 protocol can use an APPLICATION_CLOSE message with an appropriate error code to
 signal closure.
 
+If the connection has been successfully established, endpoints MUST send any
+closing frames in a 1-RTT packet.  Prior to connection establishment, endpoints
+SHOULD send closing frames in a Handshake packet if possible.  An endpoint MAY
+send closing frames in an Initial packet.  Closing frames might be replicated
+into packets at different encryption levels, which can then be coalesced (see
+{{packet-coalesce}} to facilitate retransmission.

```suggestion
{{packet-coalesce}}) to facilitate retransmission.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1890#pullrequestreview-167682003
----==_mimepart_5bcfb2401d425_18173fd0608d45bc8476
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p><b>@martinthomson</b> commented on this pull request.</p>

<hr>

<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/1890#discussi=
on_r227602227">draft-ietf-quic-transport.md</a>:</p>
<pre style=3D'color:#555'>&gt; @@ -2251,6 +2242,13 @@ the application req=
uests that the connection be closed.  The application
 protocol can use an APPLICATION_CLOSE message with an appropriate error =
code to
 signal closure.
 =

+If the connection has been successfully established, endpoints MUST send=
 any
+closing frames in a 1-RTT packet.  Prior to connection establishment, en=
dpoints
+SHOULD send closing frames in a Handshake packet if possible.  An endpoi=
nt MAY
+send closing frames in an Initial packet.  Closing frames might be repli=
cated
+into packets at different encryption levels, which can then be coalesced=
 (see
+{{packet-coalesce}} to facilitate retransmission.
</pre>
=E2=AC=87=EF=B8=8F Suggested change
<pre style=3D"color: #555">-{{packet-coalesce}} to facilitate retransmiss=
ion.
+{{packet-coalesce}}) to facilitate retransmission.
</pre>


<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/1890#pullrequestreview-167682003">view it on GitHub</=
a>, or <a href=3D"https://github.com/notifications/unsubscribe-auth/AWbkq=
5a28Nz1aWb2pBXiAC8Gr-hJHRvQks5un6nAgaJpZM4XvrnE">mute the thread</a>.<img=
 src=3D"https://github.com/notifications/beacon/AWbkq7WZF8B-MlC7F8tlS8T5P=
pNo1b7Qks5un6nAgaJpZM4XvrnE.gif" height=3D"1" width=3D"1" alt=3D"" /></p>=

<script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_versio=
n":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name"=
:"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"=
quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"http=
s://assets-cdn.github.com/images/email/message_cards/header.png","avatar_=
image_url":"https://assets-cdn.github.com/images/email/message_cards/avat=
ar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicw=
g/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mart=
inthomson commented on #1890"}],"action":{"name":"View Pull Request","url=
":"https://github.com/quicwg/base-drafts/pull/1890#pullrequestreview-1676=
82003"}}}</script>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/1890#pullrequestrev=
iew-167682003",
"url": "https://github.com/quicwg/base-drafts/pull/1890#pullrequestreview=
-167682003",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@martinthomson commented on 1890",
"sections": [
{
"text": "",
"activityTitle": "**Martin Thomson**",
"activityImage": "https://assets-cdn.github.com/images/email/message_card=
s/avatar.png",
"activitySubtitle": "@martinthomson",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/1890#pullrequestreview=
-167682003"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 3983753=
64\n}"
}
],
"themeColor": "26292E"
}
]</script>=

----==_mimepart_5bcfb2401d425_18173fd0608d45bc8476--