Re: [quicwg/base-drafts] Define stream limits as counts (#1906)
janaiyengar <notifications@github.com> Tue, 30 October 2018 02:34 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DA2E1126DBF for <quic-issues@ietfa.amsl.com>; Mon, 29 Oct 2018 19:34:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UHRaEvsLFoPZ for <quic-issues@ietfa.amsl.com>; Mon, 29 Oct 2018 19:34:07 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ADD31124C04 for <quic-issues@ietf.org>; Mon, 29 Oct 2018 19:34:07 -0700 (PDT)
Date: Mon, 29 Oct 2018 19:34:05 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540866845; bh=UUGYLWcZOol7Aki5BZTO8H7MEi+3U5BgKSsyAki0kuE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=l6dVJgm/9QiddzoM5dl8zfGLdt+YWz0mR0LWl6yvQmWnwl2773TXNngOIfHl9xojo q45hvC2oWGe6+YLRcfwKPrPnyYqtOGxPAhytlxWDY+JfJVafinZuassKZ++gcY946l JGL7UXx3T989rKNC3YzloHct3z5LRIFTNpfun4rU=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe8e2dd51721cf77bca1a257f1dd37f86482053a092cf0000000117ef851d92a169ce1646c612@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1906/review/169591740@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1906@github.com>
References: <quicwg/base-drafts/pull/1906@github.com>
Subject: Re: [quicwg/base-drafts] Define stream limits as counts (#1906)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd7c31dd235b_3d363fef6b4d45b490848"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/cm1bvBf5HwGd4TaeBgau1JzRLh8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Oct 2018 02:34:10 -0000
janaiyengar commented on this pull request. Looks great. Just one thought on the UNI/BIDI frame types. > -The MAX_STREAM_ID frame (type=0x06) informs the peer of the maximum stream ID -that they are permitted to open. +The MAX_STREAMS frame (type=0x1c and 0x1d) informs the peer of the number of +streams it is permitted to open. A MAX_STREAMS frame with a type of 0x1c +applies to bidirectional streams; a MAX_STREAMS frame with a type of 0x1d +applies to unidirectional streams. Yeah, I'm not thrilled with this either. How about we separate the frame types in the description? These are different frames, and I think it might be clearer to simply call them MAX_STREAMS_UNI and MAX_STREAMS_BIDI. > -A sender SHOULD send a STREAM_ID_BLOCKED frame (type=0x0a) when it wishes to -open a stream, but is unable to due to the maximum stream ID limit set by its -peer (see {{frame-max-stream-id}}). This does not open the stream, but informs -the peer that a new stream was needed, but the stream limit prevented the -creation of the stream. +A sender SHOULD send a STREAMS_BLOCKED frame (type=0x1e or 0x1f) when it wishes +to open a stream, but is unable to due to the maximum stream ID limit set by its +peer (see {{frame-max-streams}}). A STREAMS_BLOCKED frame of type 0x1e is used +to indicate reaching the bidirectional stream limit; a STREAMS_BLOCKED frame of +type 0x1f indicates reaching the unidirectional stream limit. Similarly, UNI_STREAMS_BLOCKED and BIDI_STREAMS_BLOCKED. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1906#pullrequestreview-169591740
- [quicwg/base-drafts] Define stream limits as coun… Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Kazuho Oku
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Marten Seemann
- Re: [quicwg/base-drafts] Define stream limits as … MikkelFJ
- Re: [quicwg/base-drafts] Define stream limits as … Nick Banks
- Re: [quicwg/base-drafts] Define stream limits as … ianswett
- Re: [quicwg/base-drafts] Define stream limits as … ianswett
- Re: [quicwg/base-drafts] Define stream limits as … ianswett
- Re: [quicwg/base-drafts] Define stream limits as … Kazuho Oku
- Re: [quicwg/base-drafts] Define stream limits as … Ryan Hamilton
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … MikkelFJ
- Re: [quicwg/base-drafts] Define stream limits as … Mike Bishop
- Re: [quicwg/base-drafts] Define stream limits as … Mike Bishop
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … janaiyengar
- Re: [quicwg/base-drafts] Define stream limits as … janaiyengar
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … ianswett
- Re: [quicwg/base-drafts] Define stream limits as … ianswett
- Re: [quicwg/base-drafts] Define stream limits as … ianswett
- Re: [quicwg/base-drafts] Define stream limits as … ianswett
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … ianswett
- Re: [quicwg/base-drafts] Define stream limits as … Ryan Hamilton
- Re: [quicwg/base-drafts] Define stream limits as … Marten Seemann
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson