Date: Fri, 20 Sep 2019 05:49:10 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJKYWQZXD7PAIHASOUXF3SIFVNEVBNHHB3EHJBY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3051/review/291140164@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3051@github.com>
References: <quicwg/base-drafts/pull/3051@github.com>
Subject: Re: [quicwg/base-drafts] Clients send datagrams with 1200 byte
 payloads (#3051)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5d84cac669cea_418e3fd64c6cd95c151365";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/crQTXlBIveMYPHVMG16oAFz6Mbk>


----==_mimepart_5d84cac669cea_418e3fd64c6cd95c151365
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett commented on this pull request.



> @@ -1592,10 +1592,10 @@ magnitude of any amplification attack that can be mounted using spoofed source
 addresses.  In determining this limit, servers only count the size of
 successfully processed packets.
 
-Clients MUST ensure that UDP datagrams containing only Initial packets are sized
-to at least 1200 bytes, adding padding to packets in the datagram as necessary.
-Sending padded datagrams ensures that the server is not overly constrained by
-the amplification restriction.
+Clients MUST ensure that UDP datagrams containing only Initial packets have
+payloads of at least 1200 bytes, adding padding to packets in the datagram as

I see your point, I added another UDP to remove the ambiguity.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3051#discussion_r326611670
----==_mimepart_5d84cac669cea_418e3fd64c6cd95c151365
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@ianswett</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3051#discussion_r326611670">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -1592,10 +1592,10 @@ magnitude of any amplification attack that can be mounted using spoofed source
 addresses.  In determining this limit, servers only count the size of
 successfully processed packets.
 
-Clients MUST ensure that UDP datagrams containing only Initial packets are sized
-to at least 1200 bytes, adding padding to packets in the datagram as necessary.
-Sending padded datagrams ensures that the server is not overly constrained by
-the amplification restriction.
+Clients MUST ensure that UDP datagrams containing only Initial packets have
+payloads of at least 1200 bytes, adding padding to packets in the datagram as
</pre>
<p>I see your point, I added another UDP to remove the ambiguity.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3051?email_source=notifications&amp;email_token=AFTOJKZEMRVM525SGQAMG6DQKTBENA5CNFSM4IYQIHG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFNHERA#discussion_r326611670">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJKY43OKAB33RZJFEKR3QKTBENANCNFSM4IYQIHGQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AFTOJK5XGZ4AXYFFTL4TDA3QKTBENA5CNFSM4IYQIHG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFNHERA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3051?email_source=notifications\u0026email_token=AFTOJKZEMRVM525SGQAMG6DQKTBENA5CNFSM4IYQIHG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFNHERA#discussion_r326611670",
"url": "https://github.com/quicwg/base-drafts/pull/3051?email_source=notifications\u0026email_token=AFTOJKZEMRVM525SGQAMG6DQKTBENA5CNFSM4IYQIHG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFNHERA#discussion_r326611670",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5d84cac669cea_418e3fd64c6cd95c151365--