Re: [quicwg/base-drafts] Add details of marking packets lost on PTO (#2624)
Nick Banks <notifications@github.com> Tue, 16 April 2019 13:57 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 676E3120463 for <quic-issues@ietfa.amsl.com>; Tue, 16 Apr 2019 06:57:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.001
X-Spam-Level:
X-Spam-Status: No, score=-8.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3i2AttrGnqhD for <quic-issues@ietfa.amsl.com>; Tue, 16 Apr 2019 06:57:34 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8FFD2120456 for <quic-issues@ietf.org>; Tue, 16 Apr 2019 06:57:34 -0700 (PDT)
Date: Tue, 16 Apr 2019 06:57:33 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555423053; bh=IR4/jvaOqbUFERWi0GlgIiimHJrsh8I6nMbHZIB4iBA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=miX6aO5CKWTiOxzcGo8OX1SadP5zMb4qNJJeIZyqX1ibJcEet0tESjudhPBAS6Mjy NZ+qOAQtZHT0TteGpWbqs16DJts0Usi9bKy0oB4ZvST3d26B/RFgXNJIA/60O+pOQs i0/TTvGXZS56zzoI36KSRUybXk5OezgRpWt0+whU=
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd17d1e1df235cfb4e77eb494f4b2e2d9ba81904692cebac311cd92a169ce19d6a975@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2624/review/227211357@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2624@github.com>
References: <quicwg/base-drafts/pull/2624@github.com>
Subject: Re: [quicwg/base-drafts] Add details of marking packets lost on PTO (#2624)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb5df4d78e30_4bb73f83afad45b8136939"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/cwieFcMjMnDX9cC9GvJ4jlCgLdk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Apr 2019 13:57:37 -0000
nibanks commented on this pull request. > @@ -623,10 +623,21 @@ time. ### Sending Probe Packets -When a PTO timer expires, the sender MUST send one ack-eliciting packet as a -probe, unless there is nothing to send. A sender MAY send up to two -ack-eliciting packets, to avoid an expensive consecutive PTO expiration due -to a single packet loss. +When a PTO timer expires, a sender MUST send at least one ack-eliciting packet +as a probe, unless there is no data available to send. An endpoint MAY send up +to two ack-eliciting packets, to avoid an expensive consecutive PTO expiration +due to a single packet loss. + +It is possible that the sender has no new or previously-sent data to send. For +example, this can happen when there is no new application data to send and all +streams with data in flight are reset (see Section 13.2 of {{QUIC-TRANSPORT}}). Maybe the best example is if the PTO timer expires and the only thing left outstanding was a spurious retransmission. For instance, packet 1 sent a stream frame, then you thought it was lost, then you sent packet 2 but then an ACK came for packet 1. Then PTO fires. You can mark that packet as possibly lost, but it wouldn't cause anything to be queued for transmit. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2624#discussion_r275810926
- [quicwg/base-drafts] Add details of marking packe… Jana Iyengar
- Re: [quicwg/base-drafts] Add details of marking p… Jana Iyengar
- Re: [quicwg/base-drafts] Add details of marking p… ianswett
- Re: [quicwg/base-drafts] Add details of marking p… Jana Iyengar
- Re: [quicwg/base-drafts] Add details of marking p… Jana Iyengar
- Re: [quicwg/base-drafts] Add details of marking p… Jana Iyengar
- Re: [quicwg/base-drafts] Add details of marking p… Jana Iyengar
- Re: [quicwg/base-drafts] Add details of marking p… Jana Iyengar
- Re: [quicwg/base-drafts] Add details of marking p… Jana Iyengar
- Re: [quicwg/base-drafts] Add details of marking p… Jana Iyengar
- Re: [quicwg/base-drafts] Add details of marking p… ianswett
- Re: [quicwg/base-drafts] Add details of marking p… Nick Banks
- Re: [quicwg/base-drafts] Add details of marking p… ianswett
- Re: [quicwg/base-drafts] Add details of marking p… ianswett
- Re: [quicwg/base-drafts] Add details of marking p… ianswett
- Re: [quicwg/base-drafts] Add details of marking p… Jana Iyengar
- Re: [quicwg/base-drafts] Add details of marking p… Jana Iyengar
- Re: [quicwg/base-drafts] Add details of marking p… Jana Iyengar
- Re: [quicwg/base-drafts] Add details of marking p… Jana Iyengar
- Re: [quicwg/base-drafts] Add details of marking p… Jana Iyengar
- Re: [quicwg/base-drafts] Add details of marking p… Jana Iyengar
- Re: [quicwg/base-drafts] Add details of marking p… ianswett
- Re: [quicwg/base-drafts] Add details of marking p… ianswett
- Re: [quicwg/base-drafts] Add details of marking p… Jana Iyengar
- Re: [quicwg/base-drafts] Add details of marking p… Jana Iyengar