Re: [quicwg/base-drafts] Clarify and split the "malformed" definition (#3352)

[Martin Thomson <[e-mail]>]

martinthomson approved this pull request.

This is lots of words, but I can't really fault them too much.

>  A server MAY send one or more PUSH_PROMISE (see {{frame-push-promise}}) or
 DUPLICATE_PUSH (see {{frame-duplicate-push}}) frames before, after, or
 interleaved with the frames of a response message. These PUSH_PROMISE and
 DUPLICATE_PUSH frames are not part of the response; see {{server-push}} for
-more details.
+more details.  These frames are not permitted in pushed responses.

```suggestion
more details.  These frames MUST NOT be sent in pushed responses.
```
or

```suggestion
more details.  A pushed response is malformed if it includes PUSH_PROMISE or DUPLICATE_PUSH frames.
```

> +    create a Host header field if one is not present in a request by
+    copying the value of the ":authority" pseudo-header field.
+
+  ":path":
+
+  : Contains the path and query parts of the target URI (the "path-absolute"
+    production and optionally a '?' character followed by the "query"
+    production (see Sections 3.3 and 3.4 of [RFC3986]).  A request in asterisk
+    form includes the value '*' for the ":path" pseudo-header field.
+
+  : This pseudo-header field MUST NOT be empty for "http" or "https"
+    URIs; "http" or "https" URIs that do not contain a path component
+    MUST include a value of '/'.  The exception to this rule is an
+    OPTIONS request for an "http" or "https" URI that does not include
+    a path component; these MUST include a ":path" pseudo-header field
+    with a value of '*' (see [RFC7230], Section 5.3.4).

I think that we should use "Section X.X of [RFCblah]" as the one form of external section references.

> +    OPTIONS request for an "http" or "https" URI that does not include
+    a path component; these MUST include a ":path" pseudo-header field
+    with a value of '*' (see [RFC7230], Section 5.3.4).
+
+All HTTP/3 requests MUST include exactly one value for the ":method", ":scheme",
+and ":path" pseudo-header fields, unless it is a CONNECT request ({{connect}}).
+An HTTP request that omits mandatory pseudo-header fields or contains invalid
+values for those fields is malformed ({{malformed}}).
+
+HTTP/3 does not define a way to carry the version identifier that is included in
+the HTTP/1.1 request line.
+
+For responses, a single ":status" pseudo-header field is defined that carries
+the HTTP status code field (see [RFC7231], Section 6).  This pseudo-header field
+MUST be included in all responses; otherwise, the response is malformed (Section
+8.1.2.6).

Fix this section reference.

> @@ -520,9 +622,13 @@ permitted (e.g., idempotent actions like GET, PUT, or DELETE).
 ### Malformed Requests and Responses {#malformed}
 
 A malformed request or response is one that is an otherwise valid sequence of
-frames but is invalid due to the presence of extraneous frames, prohibited
-header fields, the absence of mandatory header fields, or the inclusion of
-uppercase header field names.
+frames but is invalid due to:
+
+- the presence of prohibited header fields or pseudo-header fields
+- the absence of mandatory pseudo-header fields
+- invalid values for pseudo-header fields

If this is intended to be exhaustive, then you need to include ordering of pseudo-header fields and header fields.

And maybe the inclusion of a non-Final status code after a final status code.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3352#pullrequestreview-345089338