Re: [quicwg/base-drafts] Clarify and split the "malformed" definition (#3352)

Martin Thomson <notifications@github.com> Mon, 20 January 2020 05:53 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 17D64120099 for <quic-issues@ietfa.amsl.com>; Sun, 19 Jan 2020 21:53:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.3
X-Spam-Level:
X-Spam-Status: No, score=-5.3 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bESa7MDTcJ34 for <quic-issues@ietfa.amsl.com>; Sun, 19 Jan 2020 21:53:14 -0800 (PST)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 87B5F120077 for <quic-issues@ietf.org>; Sun, 19 Jan 2020 21:53:14 -0800 (PST)
Date: Sun, 19 Jan 2020 21:53:13 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579499593; bh=UW3XM4Gue4kmtfuoKf937g7vqXTdzCDBol+krK6z1IM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=tYPSYxAytyBLey4q9AZ0qr80VtdDcD8aZDz6P7VUnTBgmqqRZq2bvB0ZuK/tXimnq GDnCoEkiE8zgVmtrOPc1eehjXJuljo1Zdz40VGRVgN4+2e/EZsQ9GV0klmWMZPqaY7 gmjaTYXzAzOmbP59GPtjwBLVws/7Vx0m5PaX5q+U=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6U6A45DNOFTHCXACV4GJZMTEVBNHHCBV7VNU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3352/review/345089338@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3352@github.com>
References: <quicwg/base-drafts/pull/3352@github.com>
Subject: Re: [quicwg/base-drafts] Clarify and split the "malformed" definition (#3352)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e25404982210_641f3fc18d2cd95c218567"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/cwkBUdxqtIzsA5J9605h7bEDBBY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jan 2020 05:53:16 -0000

martinthomson approved this pull request.

This is lots of words, but I can't really fault them too much.

>  A server MAY send one or more PUSH_PROMISE (see {{frame-push-promise}}) or
 DUPLICATE_PUSH (see {{frame-duplicate-push}}) frames before, after, or
 interleaved with the frames of a response message. These PUSH_PROMISE and
 DUPLICATE_PUSH frames are not part of the response; see {{server-push}} for
-more details.
+more details.  These frames are not permitted in pushed responses.

```suggestion
more details.  These frames MUST NOT be sent in pushed responses.
```
or

```suggestion
more details.  A pushed response is malformed if it includes PUSH_PROMISE or DUPLICATE_PUSH frames.
```

> +    create a Host header field if one is not present in a request by
+    copying the value of the ":authority" pseudo-header field.
+
+  ":path":
+
+  : Contains the path and query parts of the target URI (the "path-absolute"
+    production and optionally a '?' character followed by the "query"
+    production (see Sections 3.3 and 3.4 of [RFC3986]).  A request in asterisk
+    form includes the value '*' for the ":path" pseudo-header field.
+
+  : This pseudo-header field MUST NOT be empty for "http" or "https"
+    URIs; "http" or "https" URIs that do not contain a path component
+    MUST include a value of '/'.  The exception to this rule is an
+    OPTIONS request for an "http" or "https" URI that does not include
+    a path component; these MUST include a ":path" pseudo-header field
+    with a value of '*' (see [RFC7230], Section 5.3.4).

I think that we should use "Section X.X of [RFCblah]" as the one form of external section references.

> +    OPTIONS request for an "http" or "https" URI that does not include
+    a path component; these MUST include a ":path" pseudo-header field
+    with a value of '*' (see [RFC7230], Section 5.3.4).
+
+All HTTP/3 requests MUST include exactly one value for the ":method", ":scheme",
+and ":path" pseudo-header fields, unless it is a CONNECT request ({{connect}}).
+An HTTP request that omits mandatory pseudo-header fields or contains invalid
+values for those fields is malformed ({{malformed}}).
+
+HTTP/3 does not define a way to carry the version identifier that is included in
+the HTTP/1.1 request line.
+
+For responses, a single ":status" pseudo-header field is defined that carries
+the HTTP status code field (see [RFC7231], Section 6).  This pseudo-header field
+MUST be included in all responses; otherwise, the response is malformed (Section
+8.1.2.6).

Fix this section reference.

> @@ -520,9 +622,13 @@ permitted (e.g., idempotent actions like GET, PUT, or DELETE).
 ### Malformed Requests and Responses {#malformed}
 
 A malformed request or response is one that is an otherwise valid sequence of
-frames but is invalid due to the presence of extraneous frames, prohibited
-header fields, the absence of mandatory header fields, or the inclusion of
-uppercase header field names.
+frames but is invalid due to:
+
+- the presence of prohibited header fields or pseudo-header fields
+- the absence of mandatory pseudo-header fields
+- invalid values for pseudo-header fields

If this is intended to be exhaustive, then you need to include ordering of pseudo-header fields and header fields.

And maybe the inclusion of a non-Final status code after a final status code.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3352#pullrequestreview-345089338