IETF Logo Mail Archive

Re: [quicwg/base-drafts] change the ack delay exponent to an ack delay multiplier (#2679)

MikkelFJ <notifications@github.com> Thu, 09 May 2019 06:42 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5CA8112011F for <quic-issues@ietfa.amsl.com>; Wed, 8 May 2019 23:42:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.465
X-Spam-Level:
X-Spam-Status: No, score=-6.465 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id igVymMOoLIEF for <quic-issues@ietfa.amsl.com>; Wed, 8 May 2019 23:42:53 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AF7611200CD for <quic-issues@ietf.org>; Wed, 8 May 2019 23:42:53 -0700 (PDT)
Date: Wed, 08 May 2019 23:42:52 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557384172; bh=Sph+zqqJuUcH5zu/xYE/jTrEgnCL7jBMZiFYZwp8XtQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=BL+fKm5aTdfids5bL6Xkg/TD11/L0AeuOmHX5VtIXNWxfXnFSw0L08XE3jcvOHWzG TWSE6XIb/IEaNxiy3XpqUKPnsD/HVxLQuAvaWc2xDtmNGeNmVK1aTkUzvcNsC9wuAh E+5cia/cP5ZGp/gAiWQnvxt7j15g6CfCSs8K75Xg=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYXY6BEC3OXGAZV45524D7GZEVBNHHBUWHC24@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2679/c490764779@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2679@github.com>
References: <quicwg/base-drafts/pull/2679@github.com>
Subject: Re: [quicwg/base-drafts] change the ack delay exponent to an ack delay multiplier (#2679)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cd3cbec6c96f_6e073f9822ccd9642474fb"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/d4c66l7aJndEL2cuVqBjm6Z718A>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 May 2019 06:42:55 -0000

As I say, this sets a precedence if we need to do more scales in the future. In the current form the sender decides what division is necessary. So I think there should be strong win for multiplication to prefer that.

That said, it is already messy with base 10 units, but constant mult/div by 1000 is manageable.

Another complication is overflow detection. With an exponent you can easily construct a mask. With multiplication you must either add another max var, or have another multiplication to compute it on the fly. Otherwise this will probably be an attack vector on naive implementations.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2679#issuecomment-490764779

v2.23.0 | Report a Bug | By Email