[quicwg/base-drafts] Recovery period definition is odd (#3409)

Martin Thomson <notifications@github.com> Tue, 04 February 2020 14:21 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 92A7712011C for <quic-issues@ietfa.amsl.com>; Tue, 4 Feb 2020 06:21:52 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BkQfmijGjyxb for <quic-issues@ietfa.amsl.com>; Tue, 4 Feb 2020 06:21:51 -0800 (PST)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 45B8A12011F for <quic-issues@ietf.org>; Tue, 4 Feb 2020 06:21:51 -0800 (PST)
Received: from github-lowworker-a6a2749.va3-iad.github.net (github-lowworker-a6a2749.va3-iad.github.net [10.48.16.62]) by smtp.github.com (Postfix) with ESMTP id 645336E10DD for <quic-issues@ietf.org>; Tue, 4 Feb 2020 06:21:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1580826110; bh=q3d74RszVqgGLm7DRS0OZGQSEFNHmieG/5ra4Hhmdz8=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=q0MWwTffMkzn3t0FE4TQWzcz3iNHj1Jai0fRmoJRigxHMgFNTrak8ygnHFAJHLVfx p28C+15dgXbOGb1kDpS3WSje1ADnNUyTeJvdUSTw3VCQSPY7nOxsRuRTwbwmuToQFv 0Ja/U+dtktQdeLFAUYtZc1EuL7Ku0wpvkqmVdePY=
Date: Tue, 04 Feb 2020 06:21:50 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK72M6BA6XVJ2YJMOZF4I2YH5EVBNHHCCXJBSU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3409@github.com>
Subject: [quicwg/base-drafts] Recovery period definition is odd (#3409)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e397dfe56671_19ff3fcdfe0cd968204377"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/d4dKhagJU4rNoss4EYKOGrGCAVU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Feb 2020 14:21:52 -0000

This is weird in that it assumes some context that isn't provided:

> Recovery is a period of time beginning with detection of a lost packet or an increase in the ECN-CE counter. Because QUIC does not retransmit packets, it defines the end of recovery as a packet sent after the start of recovery being acknowledged.

Perhaps instead:

> A recovery period is entered when loss or ECN-CE marking of a packet is detected.  The recovery period ends when a packet sent during the recovery period is acknowledged.

This "Because QUIC does not retransmit packets" thing is unnecessary.  I'll open a PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3409