Re: [quicwg/base-drafts] Increase resilience to spoofed Version Negotiation packets (#524)
janaiyengar <notifications@github.com> Tue, 16 May 2017 23:21 UTC
Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9DB61129B18 for <quic-issues@ietfa.amsl.com>; Tue, 16 May 2017 16:21:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.8
X-Spam-Level:
X-Spam-Status: No, score=-4.8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-2.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i383CuOcRdd1 for <quic-issues@ietfa.amsl.com>; Tue, 16 May 2017 16:21:11 -0700 (PDT)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AEAE012F9A8 for <quic-issues@ietf.org>; Tue, 16 May 2017 16:17:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=yodWK2Nn02DDUh8egeFdgsTWM/8=; b=dLcDOLSjiazqaxYq gFO0mvS8m88t3QbQTNlzVM+3PjR0A0Pc6llAV2iiyabL0ri/vJ69vcQbZ1iAQxN1 3amsYWebQKSqmfOq3WK3ZC/AawQHB/mjlBAhTTzGCHNEWgWtLI79si8oJzPaxhyW dntUk7ngY1bH9gA1mm+kxpzv3NY=
Received: by filter0591p1mdw1.sendgrid.net with SMTP id filter0591p1mdw1-16322-591B8853-1F 2017-05-16 23:16:35.243180918 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0006p1iad1.sendgrid.net (SG) with ESMTP id EzUO_UAvRF-S4GblgOMAZg for <quic-issues@ietf.org>; Tue, 16 May 2017 23:16:35.247 +0000 (UTC)
Date: Tue, 16 May 2017 16:16:35 -0700
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab42c4717b40093236526df13ae5af8d09b69457ef92cf0000000115334a5392a169ce0d99fec5@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/524/review/38537012@github.com>
In-Reply-To: <quicwg/base-drafts/pull/524@github.com>
References: <quicwg/base-drafts/pull/524@github.com>
Subject: Re: [quicwg/base-drafts] Increase resilience to spoofed Version Negotiation packets (#524)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_591b885324e75_79713f8a63a8fc3c8135"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0fd7HEqER43Wdes+CZAmicGo8JoEWxdELBf8 adYIx8ofB88zYzhhBwZ37Psp70/X3IAsdmAgN8+39atTBn76Zi0Rfp+Hfa8DZvLooT1xIqi8j1edzu 9Id/tmwqyQfS9bF2rtivx9c22yWLUMppHXlxJ8eB9IBpGFKtO/0fzWm1yXaZr4t7MeF0jnW5vUROpu g=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/dAP3GWeQuiUQO9vw3uGqSGYFEjM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 May 2017 23:21:12 -0000
janaiyengar commented on this pull request. > -uses on every packet it sends. Packets MUST continue to use long headers and -MUST include the new negotiated protocol version. +A client MUST discard a Version Negotiation packet that does not contain Packet +Number and Version fields that match those fields in a packet that the client +previously sent. This doesn't guarantee that the Version Negotiation packet is +genuine, but it reduces the chances that the packet is spoofed. + +A client that receives a valid Version Negotiation packet selects an acceptable +protocol version from those listed by the server. The client then reattempts to +create a connection using that version. Though the contents of a packet might +not change in response to version negotiation, a client MUST choose a new packet +number it uses on every packet it sends. + +If the server does not list an acceptable version, the client MAY ignore the +Version Negotiation packet. This might reduce the likelihood that a spoofed +Version Negotiation packet can be used to disrupt connection establishment. +1. I would expect the common case to be mismatch, since an attacker can easily generate a VN packet that supports a large number of known versions (minus the client's chosen). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/524#discussion_r116880042
- [quicwg/base-drafts] Increase resilience to spoof… Martin Thomson
- Re: [quicwg/base-drafts] Increase resilience to s… Mike Bishop
- Re: [quicwg/base-drafts] Increase resilience to s… janaiyengar
- Re: [quicwg/base-drafts] Increase resilience to s… janaiyengar
- Re: [quicwg/base-drafts] Increase resilience to s… janaiyengar
- Re: [quicwg/base-drafts] Increase resilience to s… Martin Thomson
- Re: [quicwg/base-drafts] Increase resilience to s… janaiyengar
- Re: [quicwg/base-drafts] Increase resilience to s… Martin Thomson
- Re: [quicwg/base-drafts] Increase resilience to s… MikkelFJ
- Re: [quicwg/base-drafts] Increase resilience to s… Martin Thomson
- Re: [quicwg/base-drafts] Increase resilience to s… Martin Thomson