IETF Logo Mail Archive

Re: [quicwg/base-drafts] Make HTTP frames a TLV format (#2235)

MikkelFJ <notifications@github.com> Wed, 06 February 2019 09:25 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0F230128D09 for <quic-issues@ietfa.amsl.com>; Wed, 6 Feb 2019 01:25:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.149
X-Spam-Level:
X-Spam-Status: No, score=-11.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id syvt1wT61nwl for <quic-issues@ietfa.amsl.com>; Wed, 6 Feb 2019 01:25:43 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F00DB12426E for <quic-issues@ietf.org>; Wed, 6 Feb 2019 01:25:42 -0800 (PST)
Date: Wed, 06 Feb 2019 01:25:41 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549445141; bh=KJaM5bMjyUxIDFN3uV5ctR3QNfn7Swb+u5I03QNeo1k=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=WRIpEWkacvymam/ftmdbfnhW75Jw2/bGMcFtjNvOMUuUKNKsQfo8YOjIaSz4/jPQ5 +/4QRWL06VHOsjrsp9ADBKMo+NNd2RwtrIJxOYGwEhERbuiAwetz38ZbdTDC0X/ItU nRU3FgEYuZ9mJoYie5Ms/UXP9fqquXAcyNyeYJYI=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab20565c748d53bddd3c5e88731e7c5e6a77b6429492cf0000000118726a1592a169ce17707fcb@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2235/review/200476079@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2235@github.com>
References: <quicwg/base-drafts/pull/2235@github.com>
Subject: Re: [quicwg/base-drafts] Make HTTP frames a TLV format (#2235)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5aa815dd898_620a3fcd96ed45c498221"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/dI_JJU4FXn819A1jNXJJ0KyRvt0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Feb 2019 09:25:45 -0000

mikkelfj commented on this pull request.



>  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
 ~~~~~~~~~~
 {: #fig-frame title="HTTP/3 frame format"}
 
 A frame includes the following fields:
 
+  Type:
+  : An 8-bit type for the frame.
+
+
   Length:
   : A variable-length integer that describes the length of the Frame Payload.
     This length does not include the Type field.
 

With reordering the "Length" description no longer makes sense. If anything, length should state that it does not include itself.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2235#pullrequestreview-200476079

v2.23.0 | Report a Bug | By Email