Re: [quicwg/base-drafts] Define stream limits as counts (#1906)
Martin Thomson <notifications@github.com> Mon, 29 October 2018 22:21 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B2DBF13104F for <quic-issues@ietfa.amsl.com>; Mon, 29 Oct 2018 15:21:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c3blACPGJ5qe for <quic-issues@ietfa.amsl.com>; Mon, 29 Oct 2018 15:21:18 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D3BEB131030 for <quic-issues@ietf.org>; Mon, 29 Oct 2018 15:21:17 -0700 (PDT)
Date: Mon, 29 Oct 2018 15:21:16 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540851676; bh=S28SZhb4vlZQV0SZhMSLlKW+C29n3mn0WWJGBJsfTP0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=uhnM3A2y/+yYSuTc0zh3UDgkHpsNrzg07ObtmveGW/3m1puDEiGi0AqX+Ip5viJiK PNCPDy0PB9My0VzIaC9BcPY95fNoqCMZvpN/xp4SW4/9VLF/8f2P4VnE0LYQgIle99 g8jP/V1yA5JdDIXvf/MFhdLvNbXHsvunGCkZtcQE=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8a3319c82bbd3111e4a25b0e391afa1ce395213a92cf0000000117ef49dc92a169ce1646c612@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1906/review/169541747@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1906@github.com>
References: <quicwg/base-drafts/pull/1906@github.com>
Subject: Re: [quicwg/base-drafts] Define stream limits as counts (#1906)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd787dcc0df4_43333f8611ad45b8251627"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/dKTJy-sKokwyIUzUmayhb5Q2z4A>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Oct 2018 22:21:20 -0000
martinthomson commented on this pull request. Not detecting any objections, and lots of approval, I think that I'm going to merge this one. I'll mail the list first though. > initiate. Each endpoint may respond on streams initiated by the other peer, regardless of whether it is permitted to initiate new streams. Endpoints MUST NOT exceed the limit set by their peer. An endpoint that receives a STREAM frame with an ID greater than the limit it has sent MUST treat -this as a stream error of type STREAM_ID_ERROR ({{error-handling}}), unless this -is a result of a change in the initial limits (see {{zerortt-parameters}}). +this as a stream error of type STREAM_LIMIT_ERROR ({{error-handling}}), unless +this is a result of a change in the initial limits (see {{zerortt-parameters}}). Cutting that. I didn't think much on it before, but you are right that it's nonsensical. > -The STREAM_ID_BLOCKED frame ({{frame-stream-id-blocked}}) can be -used to signal a shortage of available streams. Implementations will likely -want to increase the maximum stream ID as peer-initiated streams close. +The STREAMS_BLOCKED frame ({{frame-streams-blocked}}) signals that a new stream I had exactly the same thought. It's just that I can't think of a better name. > -The MAX_STREAM_ID frame (type=0x06) informs the peer of the maximum stream ID -that they are permitted to open. +The MAX_STREAMS frame (type=0x1c and 0x1d) informs the peer of the number of +streams it is permitted to open. A MAX_STREAMS frame with a type of 0x1c +applies to bidirectional streams; a MAX_STREAMS frame with a type of 0x1d +applies to unidirectional streams. I just tried this. Describing using a flag means more words, and I think that it's a small regression in terms of clarity. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1906#pullrequestreview-169541747
- [quicwg/base-drafts] Define stream limits as coun… Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Kazuho Oku
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Marten Seemann
- Re: [quicwg/base-drafts] Define stream limits as … MikkelFJ
- Re: [quicwg/base-drafts] Define stream limits as … Nick Banks
- Re: [quicwg/base-drafts] Define stream limits as … ianswett
- Re: [quicwg/base-drafts] Define stream limits as … ianswett
- Re: [quicwg/base-drafts] Define stream limits as … ianswett
- Re: [quicwg/base-drafts] Define stream limits as … Kazuho Oku
- Re: [quicwg/base-drafts] Define stream limits as … Ryan Hamilton
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … MikkelFJ
- Re: [quicwg/base-drafts] Define stream limits as … Mike Bishop
- Re: [quicwg/base-drafts] Define stream limits as … Mike Bishop
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … janaiyengar
- Re: [quicwg/base-drafts] Define stream limits as … janaiyengar
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … ianswett
- Re: [quicwg/base-drafts] Define stream limits as … ianswett
- Re: [quicwg/base-drafts] Define stream limits as … ianswett
- Re: [quicwg/base-drafts] Define stream limits as … ianswett
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson
- Re: [quicwg/base-drafts] Define stream limits as … ianswett
- Re: [quicwg/base-drafts] Define stream limits as … Ryan Hamilton
- Re: [quicwg/base-drafts] Define stream limits as … Marten Seemann
- Re: [quicwg/base-drafts] Define stream limits as … Martin Thomson