Re: [quicwg/base-drafts] Define initial PRIORITY frame and remove exclusive dependencies (#2075)

Mike Bishop <notifications@github.com> Thu, 06 December 2018 22:44 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 21DC11311F0 for <quic-issues@ietfa.amsl.com>; Thu, 6 Dec 2018 14:44:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.46
X-Spam-Level:
X-Spam-Status: No, score=-4.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KUE9QqwOAa6w for <quic-issues@ietfa.amsl.com>; Thu, 6 Dec 2018 14:44:40 -0800 (PST)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BB84B130F35 for <quic-issues@ietf.org>; Thu, 6 Dec 2018 14:44:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=ZjorYlO39i2QYKoT8Oj1/cmVXAU=; b=l+MZJinOJicKJPvs RKH4pOPonFDPlHavevbxvJNC+KDyUUjyLSzA6hm6XQWR15EeIkz9FDQHaxEC2rnK DmtYhBjJDdYuWIRHs3KLjC5IQ/a/NPOFSva4GYg7iCZIDW3gJNElge86Pc2bganl +6lfMp4IAKDA5ID0dnNEy8RM8+A=
Received: by filter0403p1iad2.sendgrid.net with SMTP id filter0403p1iad2-8371-5C09A656-1F 2018-12-06 22:44:38.698357476 +0000 UTC m=+249818.988903141
Received: from github-lowworker-fc273f0.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0042p1iad1.sendgrid.net (SG) with ESMTP id _eCBeQOrRkG8KEKc1qZykw for <quic-issues@ietf.org>; Thu, 06 Dec 2018 22:44:38.346 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-fc273f0.cp1-iad.github.net (Postfix) with ESMTP id 5200DC0DEE for <quic-issues@ietf.org>; Thu, 6 Dec 2018 14:44:38 -0800 (PST)
Date: Thu, 06 Dec 2018 22:44:38 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abc7ec2ddfd3ec6a827470e20584c2bec6b3aab7ef92cf000000011821685692a169ce17019477@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2075/review/182484139@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2075@github.com>
References: <quicwg/base-drafts/pull/2075@github.com>
Subject: Re: [quicwg/base-drafts] Define initial PRIORITY frame and remove exclusive dependencies (#2075)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c09a6564f70d_453b3feb8ced45c41388af"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak10KrkEzI2LxQN3phQFkdgf2djOwvPbAIHPVn O93pBNn7YhKzOZC1BcleFPQMhMZvkgLFIBYmGqd9NCDUN9kJIn9elt/ZJdosg0X8MD2zpPWzv8qbPv Qx/crGa/0eF/2ErQ332ygTUZDNaxK9w7349xVc94lV0h79Gtv87CpAzc5pcJhFlJT0o4FyiDBrRsMP 8=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/dLAwmhV7IYd3LmXLKmOjH8iteqE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Dec 2018 22:44:42 -0000

MikeBishop commented on this pull request.



> @@ -552,10 +553,11 @@ the interpretation of the associated Element ID fields.
 Note that the root of the tree cannot be referenced using a Stream ID of 0, as
 in {{!RFC7540}}; QUIC stream 0 carries a valid HTTP request.  The root of the
 tree cannot be reprioritized. A PRIORITY frame sent on a request stream that
-prioritizes any other stream MUST be treated as a stream error of type
-HTTP_MALFORMED_FRAME.  Likewise, a PRIORITY frame sent on a control stream that
-prioritizes the current stream MUST be treated as a connection error of type
-HTTP_MALFORMED_FRAME.
+prioritizes any other stream or expresses a dependency on a request with a

Good point.  The requirement for the values was already there (in the definition of Prioritized Element Type), but I'll scope the required-error language to the specific values as well.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2075#discussion_r239642920