Date: Mon, 12 Nov 2018 02:00:55 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4aba2cf50d3e4ad69f111d55147a2634daf060ab94792cf000000011801115792a169ce16a1bb2f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1992/review/173823447@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1992@github.com>
References: <quicwg/base-drafts/pull/1992@github.com>
Subject: Re: [quicwg/base-drafts] Endpoint MAY discard CIDs (#1992)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5be94f572058c_3f1f3fdd458d45c0913b3";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/dRCTYncMDkOIvMcEF9pLL7krQuc>


----==_mimepart_5be94f572058c_3f1f3fdd458d45c0913b3
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

martinthomson approved this pull request.



>  
 When an endpoint issues a connection ID, it MUST accept packets that carry this
 connection ID for the duration of the connection or until its peer invalidates
 the connection ID via a RETIRE_CONNECTION_ID frame
 ({{frame-retire-connection-id}}).
 
+Endpoints store received connection IDs for future use.  An endpoint that
+receives excessive connection IDs MAY discard those it cannot store.  An
+endpoint that issues connection IDs should expect that its peer might not store

```suggestion
endpoint that issues connection IDs cannot expect its peer to store
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1992#pullrequestreview-173823447
----==_mimepart_5be94f572058c_3f1f3fdd458d45c0913b3
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p><b>@martinthomson</b> approved this pull request.</p>

<hr>

<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/1992#discussi=
on_r232594578">draft-ietf-quic-transport.md</a>:</p>
<pre style=3D'color:#555'>&gt;  =

 When an endpoint issues a connection ID, it MUST accept packets that car=
ry this
 connection ID for the duration of the connection or until its peer inval=
idates
 the connection ID via a RETIRE_CONNECTION_ID frame
 ({{frame-retire-connection-id}}).
 =

+Endpoints store received connection IDs for future use.  An endpoint tha=
t
+receives excessive connection IDs MAY discard those it cannot store.  An=

+endpoint that issues connection IDs should expect that its peer might no=
t store
</pre>
=E2=AC=87=EF=B8=8F Suggested change
<pre style=3D"color: #555">-endpoint that issues connection IDs should ex=
pect that its peer might not store
+endpoint that issues connection IDs cannot expect its peer to store
</pre>


<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/1992#pullrequestreview-173823447">view it on GitHub</=
a>, or <a href=3D"https://github.com/notifications/unsubscribe-auth/AWbkq=
4mOx6JsvDmUHLGARJmLKKV9IyEeks5uuUbXgaJpZM4YZTGe">mute the thread</a>.<img=
 src=3D"https://github.com/notifications/beacon/AWbkq1KTs4CYsuKV9M4ZyOxpl=
wilZZXJks5uuUbXgaJpZM4YZTGe.gif" height=3D"1" width=3D"1" alt=3D"" /></p>=

<script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_versio=
n":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name"=
:"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"=
quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"http=
s://assets-cdn.github.com/images/email/message_cards/header.png","avatar_=
image_url":"https://assets-cdn.github.com/images/email/message_cards/avat=
ar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicw=
g/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mart=
inthomson approved #1992"}],"action":{"name":"View Pull Request","url":"h=
ttps://github.com/quicwg/base-drafts/pull/1992#pullrequestreview-17382344=
7"}}}</script>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/1992#pullrequestrev=
iew-173823447",
"url": "https://github.com/quicwg/base-drafts/pull/1992#pullrequestreview=
-173823447",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@martinthomson approved 1992",
"sections": [
{
"text": "",
"activityTitle": "**Martin Thomson**",
"activityImage": "https://assets-cdn.github.com/images/email/message_card=
s/avatar.png",
"activitySubtitle": "@martinthomson",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/1992#pullrequestreview=
-173823447"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 4092850=
22\n}"
}
],
"themeColor": "26292E"
}
]</script>=

----==_mimepart_5be94f572058c_3f1f3fdd458d45c0913b3--