Re: [quicwg/base-drafts] Move and consolidate address validation (#1886)

janaiyengar <notifications@github.com> Tue, 23 October 2018 23:29 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0C3D4130E5F for <quic-issues@ietfa.amsl.com>; Tue, 23 Oct 2018 16:29:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.47
X-Spam-Level:
X-Spam-Status: No, score=-3.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1I1sROd08ssu for <quic-issues@ietfa.amsl.com>; Tue, 23 Oct 2018 16:28:59 -0700 (PDT)
Received: from o11.sgmail.github.com (o11.sgmail.github.com [167.89.101.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 12BC2130E58 for <quic-issues@ietf.org>; Tue, 23 Oct 2018 16:28:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=gqv4m5i5yYiY7eein3uDrqKweXk=; b=Qlc+BhZua+awqloJ CKcO5UHuuW5cASf49itEpb+CyEBW73x50R9NVsFrP1+Fd7UO9A5ADii140iJG/dr 07gpet12G+dnpr3PDDOQnXsBpXZllCkUgU2yVBIZToKY9G7Zclh14TBXxVB+AJjM u34WotTodZo8GuxjDkyyOGMJTmk=
Received: by filter0199p1iad2.sendgrid.net with SMTP id filter0199p1iad2-25355-5BCFAEB9-18 2018-10-23 23:28:57.764669811 +0000 UTC m=+420897.790945801
Received: from github-lowworker-e51511d.cp1-iad.github.net (unknown [192.30.252.34]) by ismtpd0015p1iad2.sendgrid.net (SG) with ESMTP id WiGsaiKBTNSDGOmi4eQ7LA for <quic-issues@ietf.org>; Tue, 23 Oct 2018 23:28:57.709 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e51511d.cp1-iad.github.net (Postfix) with ESMTP id B64F080071 for <quic-issues@ietf.org>; Tue, 23 Oct 2018 16:28:57 -0700 (PDT)
Date: Tue, 23 Oct 2018 23:28:58 +0000
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab75c57346aaa3870a34cfa84f854257819581d8a392cf0000000117e770b992a169ce1628c016@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1886/review/167678790@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1886@github.com>
References: <quicwg/base-drafts/pull/1886@github.com>
Subject: Re: [quicwg/base-drafts] Move and consolidate address validation (#1886)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bcfaeb9b4bd7_2f043f9b428d45c4131211"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3UdWt/Mow/VVfeK8qB++aVeF3kfVywLMr425 MSWm6smTDSIMe7hoP3/2J1fkm9VJXVtDdZXtqUi8tIx08sA053ObIDOMQVRzOZnEKwv0MpvxX6xs9f QqjQXtvK2KiTTBm5JiIzXur5DTn9vYt/FgH38LpuMnpeTrvYwLOXs8RPa0S7tT+5XPNZ2UfQ2hsqMd s=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/dUOSck8mPFXfOm-Q5v1hsYwpLlM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Oct 2018 23:29:01 -0000

janaiyengar commented on this pull request.



> +
+The server uses the NEW_TOKEN frame {{frame-new-token}} to provide the client
+with an address validation token that can be used to validate future
+connections.  The client may then use this token to validate future connections
+by including it in the Initial packet's header.  The client MUST NOT use the
+token provided in a Retry for future connections.
+
+Unlike the token that is created for a Retry packet, there might be some time
+between when the token is created and when the token is subsequently used.
+Thus, a resumption token SHOULD include an expiration time.  The server MAY
+include either an explicit expiration time or an issued timestamp and
+dynamically calculate the expiration time.  It is also unlikely that the client
+port number is the same on two different connections; validating the port is
+therefore unlikely to be successful.
+
+A resumption token SHOULD be easily distinguishable from tokens that are sent in

```suggestion
A resumption token SHOULD be constructed to be easily distinguishable from tokens that
are sent in Retry packets as they are carried in the same field.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1886#pullrequestreview-167678790