Re: [quicwg/base-drafts] Transport parameters are mandatory. Fixes #2528 (#2560)

Martin Thomson <notifications@github.com> Wed, 27 March 2019 08:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B7984120276 for <quic-issues@ietfa.amsl.com>; Wed, 27 Mar 2019 01:46:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.001
X-Spam-Level:
X-Spam-Status: No, score=-8.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a3w9tQeKVSW1 for <quic-issues@ietfa.amsl.com>; Wed, 27 Mar 2019 01:46:36 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7CCB912027A for <quic-issues@ietf.org>; Wed, 27 Mar 2019 01:46:36 -0700 (PDT)
Date: Wed, 27 Mar 2019 01:46:35 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1553676395; bh=PAD3RvV+SUfr7gzn3BzOO9KTpDYKo6L9K8NtknR5ziI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=K9qOV/wl+iP2kpwy4p9ZT+Q+32IoY3hVl+Mf0UCx2LiFS6YAwd5h+HPkctC0T58as 5ShZDJlpB4v/wX/l66UJWv5/tgtkZnRSjctM0gsXv0q9q7Dn1oJpVhK+2pkou0Prce VlUkcVjS/09oFUiXWAZrEKbBD2XCVAzoXLq67rxA=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe398c15bb6454c80b9858e898a4e65dafa86295b92cf0000000118b2fa6b92a169ce1961a1eb@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2560/review/219326366@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2560@github.com>
References: <quicwg/base-drafts/pull/2560@github.com>
Subject: Re: [quicwg/base-drafts] Transport parameters are mandatory. Fixes #2528 (#2560)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c9b386b5c300_697d3fa72d6d45c022821d"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/dUTgsHtgx3mtDA9JTqHxaLLiuYQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Mar 2019 08:46:39 -0000

martinthomson approved this pull request.



> @@ -1249,7 +1249,10 @@ quic_transport_parameters extension carries a TransportParameters struct when
 the version of QUIC defined in {{QUIC-TRANSPORT}} is used.
 
 The quic_transport_parameters extension is carried in the ClientHello and the
-EncryptedExtensions messages during the handshake.
+EncryptedExtensions messages during the handshake. Endpoints MUST send the
+quic_transport_parameters extension; endpoints which receive ClientHello

```suggestion
quic_transport_parameters extension; endpoints that receive ClientHello
```
CMOS

> @@ -1249,7 +1249,10 @@ quic_transport_parameters extension carries a TransportParameters struct when
 the version of QUIC defined in {{QUIC-TRANSPORT}} is used.
 
 The quic_transport_parameters extension is carried in the ClientHello and the
-EncryptedExtensions messages during the handshake.
+EncryptedExtensions messages during the handshake. Endpoints MUST send the
+quic_transport_parameters extension; endpoints which receive ClientHello
+or EncryptedExtensions messages without the transport_parameters extension MUST

```suggestion
or EncryptedExtensions messages without the quic_transport_parameters extension MUST
```

> @@ -1249,7 +1249,10 @@ quic_transport_parameters extension carries a TransportParameters struct when
 the version of QUIC defined in {{QUIC-TRANSPORT}} is used.
 
 The quic_transport_parameters extension is carried in the ClientHello and the
-EncryptedExtensions messages during the handshake.
+EncryptedExtensions messages during the handshake. Endpoints MUST send the
+quic_transport_parameters extension; endpoints which receive ClientHello
+or EncryptedExtensions messages without the transport_parameters extension MUST
+terminate the TLS handshake with a fatal missing_extension alert.

```suggestion
terminate the TLS handshake with a fatal missing_extension alert (an error of 0x16d).
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2560#pullrequestreview-219326366